Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import passwords for Microsoft Edge and Vivaldi #14559

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Aug 9, 2022

Resolves brave/brave-browser#24343
Resolves brave/brave-browser#24578

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Import passwords from Microsoft Edge for OSX

@spylogsster spylogsster changed the title Import passwords for Microsoft Edge Import passwords for Microsoft Edge and Vivaldi Aug 11, 2022
@spylogsster spylogsster force-pushed the brave-24343 branch 5 times, most recently from 754f236 to 97cfdd3 Compare August 16, 2022 05:55
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PW import on both browsers using macOS (arm64) and it worked perfect
Screen Shot 2022-08-15 at 11 07 30 PM
Screen Shot 2022-08-15 at 11 18 42 PM

Code changes look great 😄👍

@spylogsster spylogsster force-pushed the brave-24343 branch 4 times, most recently from ba60110 to 8e5d5d3 Compare August 16, 2022 15:14
@kjozwiak
Copy link
Member

Verified for uplift by @stephendonner via #14663 (comment) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants