-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DNS.Resolvers IPNS config property if user disables DOH #24678
Comments
The above will require |
We can |
Verification
|
Brave | 1.43.81 Chromium: 104.0.5112.102 (Official Build) (x86_64) |
---|---|
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478} |
OS | macOS Version 11.6.8 (Build 20G730) |
Steps:
- installed
1.43.81
- launched Brave
- loaded
brave://ipfs-internals/
- clicked on
Install and start
- chose
NextDNS
as a DoH provider inbrave://settings/security
- shut down Brave
- opened
{profile_folder}/brave_ipfs/config
in a text editor - confirmed there's a DNS entry with
Resolvers:
andNextDNS
is listed - relaunch Brave
- set DNS back to
With your current service provider
- loaded
ipns://ipfs.io
- clicked on
Use a local Brave IPFS node
- waited for
ipns://ipfs.tech/
to finish loading - shut down Brave
- opened
{profile_folder}/brave_ipfs/config
in a text editor - searched for
DNS
/Resolver
Confirmed the DNS Resolver
section was removed
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
Dns override doesn't falls back when DOH removed.
Config still contains DNS.Resolvers property after user switches to system DNS.
The text was updated successfully, but these errors were encountered: