DNS resolver doesn't get reset after enabling, then disabling, DoH for IPNS

[stephendonner]

Description

DNS resolver doesn't get reset after enabling, then disabling, DoH for IPNS

Found while testing #24678.

Steps to Reproduce

1. install 1.44.62
2. launch Brave
3. load brave://ipfs-internals/
4. click on Install and start
5. chose NextDNS as a DoH provider in brave://settings/security
6. shut down Brave
7. opened {profile_folder}/brave_ipfs/config in a text editor
8. confirmed there's a DNS entry with Resolvers: and NextDNS is listed
9. relaunch Brave
10. set DNS back to With your current service provider
11. shut down Brave
12. opened {profile_folder}/brave_ipfs/config in a text editor
13. searched for DNS / Resolver

Actual result:

Expected result:

No DNS / Resolvers entry

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.44.62 Chromium: 104.0.5112.102 (Official Build) nightly (x86_64)
Revision	8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS	macOS Version 11.6.8 (Build 20G730)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @cypt4

[cypt4]

@stephendonner , I think config will be updated after local node relaunch. Could you recheck the testcase but after 10 open some ipfs:// or ipns:// site?

[stephendonner]

@stephendonner , I think config will be updated after local node relaunch. Could you recheck the testcase but after 10 open some ipfs:// or ipns:// site?

Retested the above using

Brave	1.44.64 Chromium: 105.0.5195.37 (Official Build) nightly (x86_64)
Revision	5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS	macOS Version 11.6.8 (Build 20G730)

Confirmed working; if I add the step of loading ipns://ipfs.io after changing back to regular DNS from DoH, the NextDNS entry is removed 👍

11. load ipns://ipfs.io
12. click on Brave local IPNS node 13. let it load
13. shut down Brave
14. open {profile_dir}/ipfs_folder/config, I no longer see the DNS/ NextDNS entry

[stephendonner]

With the above added step, this fix works for me, so closing this issue off as WORKSFORME. Will verify over in #24678 👍