Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add griffin feature flag for setting Llama13B as the default #34721

Closed
bbondy opened this issue Dec 5, 2023 · 5 comments · Fixed by brave/brave-core#21398
Closed

Add griffin feature flag for setting Llama13B as the default #34721

bbondy opened this issue Dec 5, 2023 · 5 comments · Fixed by brave/brave-core#21398

Comments

@bbondy
Copy link
Member

bbondy commented Dec 5, 2023

  • Change the default to Mixtral
  • Make it controllable via a feature flag that we can set remotely to make it go to Llama2 13B as the default
@bbondy
Copy link
Member Author

bbondy commented Dec 5, 2023

cc @petemill @nullhook

@bbondy
Copy link
Member Author

bbondy commented Dec 20, 2023

FYI @petemill: Updated to Mixtral

@petemill
Copy link
Member

The feature flags available are:

is_freemium_available - if true then all freemium models are actually freemium, if false then all freemium models are only available to premium users.

default_model - hard-coded value is chat-leo-expanded (mistral). If we disable freemium from the server-side, then we would change this in feature flag to chat-basic.

default_premium_model - hard-coded value is chat-leo-expanded. We would probably just keep this the same.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 19, 2024

The above requires 1.62.147 or higher for 1.62.x verification 👍 STR/Cases can be found via the verifications that @stephendonner completed via brave/brave-core#21398 (comment).

@stephendonner
Copy link

stephendonner commented Jan 22, 2024

Verified PASSED using

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (x86_64)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.62.149
  2. launched Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev --enable-logging=stderr
  3. clicked on Leo in the sidebar
  4. typed test
  5. clicked on Accept and begin
  6. loaded wired.com
  7. loaded an article
  8. clicked on Summarize this page
  9. clicked on Suggest questions...
  10. opened brave://settings/leo-assistant

Confirmed Mixtral as the default non-Premium LLM

example example example example
Screen Shot 2024-01-22 at 1 07 05 PM Screen Shot 2024-01-22 at 1 07 13 PM Screen Shot 2024-01-22 at 1 04 01 PM Screen Shot 2024-01-22 at 1 05 11 PM
1st launch 2nd launch default settings
Screen Shot 2024-01-22 at 12 59 59 PM Screen Shot 2024-01-22 at 1 00 11 PM Screen Shot 2024-01-22 at 1 01 43 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants