Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Leo default model to Llama 3 8b (25% rollout) #1225

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nvonpentz
Copy link
Member

@nvonpentz nvonpentz commented Oct 15, 2024

Related to brave/brave-core#21398
Blocked on deploying https:/brave/aichat-ops/pull/359 to prod

This sets the default model for 25% of free users to chat-basic, which corresponds to Llama 3 8b.

The intention is to start this to progressively roll out this change (25%, 50%, 75%, 100%), so we can ensure our single instance of Llama 3 can handle the increase in traffic. Based on these estimations, one instance of llama 3 (one gpu) should have higher token throughput than our single instance of mixtral (four gpus), so we expect this to work with two llama instances which will be added in https:/brave/aichat-ops/pull/359.

cc @petemill @LorenzoMinto

Note:

Copy link
Contributor

github-actions bot commented Oct 15, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1225.
    Android: Set the command line to --variations-pr=1225 in debug menu, restart the browser.
    iOS: Set Variations PR to 1225 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1225@02be91adb07839f2668690152f397b0a9ec4c0c2
Uploaded Thu, 17 Oct 2024 14:10:54 GMT
PR commit ed3f1df
Base commit 024f17f
Merge commit 02be91a
Serial number 2b5fac7fc29881a4c81bbafb69157d15

seed/seed.json Outdated
"BETA",
"NIGHTLY"
],
"min_version": "122.0.6261.57",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like in this file the versioning is [chrome_major].[brave_version], e.g 122.1.63.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to use 122.1.63.161 as the min version of the default model change. 1.63.161 seems to be the first 1.63 release. This also adds in a little buffer because brave/brave-browser#34721 was uplifted into 1.62.x.

I specified 122.1.63.160 as the new max version for the previous setting. This may not correlate to an actual release, it's just one patch version behind 122.1.63.161.

@petemill
Copy link
Member

I tested running with --enable-features=AIChat:default_model\/chat-basic and all seems fine

Use [chrome_major].[brave_version] format, not just the chromium
version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants