Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Filecoin feature by default on Desktop #13554

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Enable Filecoin feature by default on Desktop #13554

merged 1 commit into from
Jun 14, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 1, 2022

Resolves brave/brave-browser#23169

Security review https:/brave/security/issues/889

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

There are unit tests cover the default value of the feature flag check on desktop and android.

@spylogsster spylogsster requested a review from a team as a code owner June 1, 2022 06:06
@spylogsster spylogsster requested review from yrliou and bbondy June 1, 2022 06:07
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending security approval

@darkdh
Copy link
Member

darkdh commented Jun 3, 2022

blocked by brave/brave-browser#23241
we shouldn't enable it unless above issue is resolved

@yrliou
Copy link
Member

yrliou commented Jun 14, 2022

blocked by brave/brave-browser#23241 we shouldn't enable it unless above issue is resolved

Not blocking by this anymore as we disable testnet via #13732.

@yrliou yrliou assigned yrliou and unassigned spylogsster Jun 14, 2022
@yrliou yrliou requested review from darkdh and removed request for yrliou June 14, 2022 04:30
@yrliou yrliou changed the title Enable Filecoin feature by default Enable Filecoin feature by default on Desktop Jun 14, 2022
@yrliou yrliou force-pushed the brave-23169 branch 2 times, most recently from a7de417 to 1d5b879 Compare June 14, 2022 04:37
@yrliou yrliou merged commit bda6e1b into master Jun 14, 2022
@yrliou yrliou deleted the brave-23169 branch June 14, 2022 06:49
brave-builds pushed a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Filecoin feature by default on Desktop
4 participants