-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only filecoin mainnet by default #13732
Conversation
3c2ba0d
to
6d2defc
Compare
290a0ce
to
e7fa077
Compare
IsFilecoinTestnetEnabled() ? mojom::kFilecoinTestnet | ||
: mojom::kFilecoinMainnet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in DM, please add comment here to explain why this is fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resoves brave/brave-browser#23367 Put filecoin testnet under feature flag, mainnet is by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this line
https:/brave/brave-core/blob/master/components/brave_wallet_ui/components/desktop/network-filter-selector/index.tsx#L94
to something like this
{/* Disabled Filecoin Submenu until testnetworks are enabled */}
{isTestNetworksEnabled && network.coin !== BraveWallet.CoinType.FIL &&
That away it will prevent this Submenu
for Filecoin
until test networks are supported.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use only filecoin mainnet by default
Verification passed on
|
Edit: Verified sending FIL coin on mainnet works fine. |
Use only filecoin mainnet by default
Resolves brave/brave-browser#23367
Put filecoin testnet under feature flag, mainnet is by default
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please note that there may be artifacts when update brave with existed filecoin accs created before this PR, but it is ok because real users don't have filecoin accs yet.