Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable auto-update for windows #552

Closed
alfred-landrum opened this issue Apr 4, 2020 · 2 comments · Fixed by #744
Closed

enable auto-update for windows #552

alfred-landrum opened this issue Apr 4, 2020 · 2 comments · Fixed by #744
Assignees
@mason-fish
Labels
bug Something isn't working

Comments

@alfred-landrum
Copy link
Contributor

alfred-landrum commented Apr 4, 2020 •
edited
Loading

Now that we have code-signing support for our windows builds, we should be able to create the zip needed for the auto-update code.

EDIT: Our reading of the docs says that the exe file we produce should be enough for windows auto-update to work, but it doesn't appear to do so on the recent v0.7.0 release.
@alfred-landrum alfred-landrum changed the title create windows artifacts to enable auto-update enable auto-update for windows Apr 14, 2020
@philrz philrz added the bug Something isn't working label Apr 30, 2020
@philrz
Copy link
Contributor

philrz commented Apr 30, 2020

@mason-fish believes this is due to us not handling our auto-update message in Electron the way we should.

@mason-fish mason-fish self-assigned this May 4, 2020
@mason-fish mason-fish mentioned this issue May 5, 2020
Merged
@philrz
Copy link
Contributor

philrz commented May 6, 2020

Verified in Brim tagged v0.9.1. I started out running the short-lived v0.9.0 release, and after launching and waiting less than a minute, I was prompted.

image

Once I let it restart, I could confirm I was running the new version.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mason-fish mason-fish

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix windows autoupdate brimdata/zui
3 participants
@alfred-landrum @philrz @mason-fish