fix windows autoupdate #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfred-landrum
approved these changes
May 5, 2020
There was a problem hiding this comment.
🎉 . @mason-fish : can you clarify how we should describe this for release notes? Am I correct to say that once a user installs a release with this change (which will likley be v0.9.0), then auto-update should work going forward, correct? But users that have an already released Brim will need to install v0.9.0 manually.
fyi @philrz
|
@alfred-landrum Yes that's correct. So we can expect the first wave of windows autoupdates to trigger when we release |
jameskerr
approved these changes
May 5, 2020
|
If you rebase you won't run into that format error anymore. |
added 9 commits
May 5, 2020 12:00
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
Signed-off-by: Mason Fish <[email protected]>
mason-fish
force-pushed
the
552-fix_windows_autoupdate
branch
from
30f5119
to
5ccf17d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #552
After digging through a fair amount of (un)documentation, the fix here has a few pieces but they are all small:
First off, there is a bizarre and inconsistent issue where if we try to run the updater immediately on startup then there can be an issue with multiple processes racing for resources. I only saw this once but since I added the 30s delay I never saw it again.
Second, the
path.joinworks great for cross platform filepaths, but is not designed for url construction.Third, in addition to the *.exe file, we also need to begin publishing the
RELEASESand*.nupkgfiles which are already being generated by winstaller.