Support for ui-router resolve, onEnter and onExit

[ghengeveld]

Since ui-router of the angular-ui project is quickly becoming the de-facto replacement of Angular's routeProvider, it would be good to have full support for it. This means that the 'resolve', 'onEnter' and 'onExit' properties in $stateProvider.state() should be handled by ngmin.

@see https:/angular-ui/ui-router/wiki#onenter-and-onexit-callbacks

[ivangarcia2]

+1

[arebelrossi]

+1

[battika]

+1

[braco]

+1

[dylan-baskind]

+1

Took me awhile to figure out that this was where my minified code was going bust.

Does anyone have any stop-gap solution for converting the standard form of these functions, i.e.

            # To Do...
            projectData: (someInjectable) ->
                # Return some data

To a minification safe form?

Apologies if this is a noob type question!

D.

[forgetaboutit]

@dylan-baskind : in our project, we're using

# To do ...
projectData: ["someInjectable", (someInjectable) ->
    # Return some data
]

[dylan-baskind]

@forgetaboutit - Cheers for that!

Familiar syntax from the controller declarations, just didn't realise it would also apply here. Thanks for the tip.

[gbockus]

+1

[hengkiardo]

+1

[liujinxing]

+1

[leon]

+1

[towu]

+1

[27leaves]

+1

[liujinxing]

+1

[cmcnamara87]

+1

[stto3703]

+1

[btford]

I think #61 will make this easier, so I'll work on getting this in ASAP. :)

[luisfarzati]

+1

[futurechan]

+1

[martijnve]

+1

[vrodriguezTecsisa]

+1

[julianpaulozzi]

+1

[jketcham]

👍

[inetfuture]

+1

[Urigo]

+1 :)

[mablk]

+1

[demetriusnunes]

+1

[donaldpipowitch]

Hi guys,

if you need this feature I would recommend to try ng-annotate, which supports this in its new bleeding edge version (see here for examples).

// cc @olov

[pensierinmusica]

+1 :)

[andycaramba]

and up again 👍

[kikonen-fiksu]

Changes that any fixes for this are merged some day? i.e. I just hit trouble with ngmin and "ui-router" "resolve"s.

[donaldpipowitch]

Seriously, check ng-annotate. Here is a comparison between ng-annotate and ngmin.

[kikonen-fiksu]

Q: does it have rails assets pipeline integration?

[olov]

@donaldpipowitch That link shows which 24 open ngmin issues that just work in ng-annotate. In addition, there are 6 open ngmin issues that work in ng-annotate with a workaround. See full annotated issue list.

But Instead of just looking at that list I recommend reading the more elaborate comparison I wrote yesterday in issue #93 - The future of ngmin and ng-annotate. @kikonen-fiksu: That comparison also describes where ng-annotate is trailing ngmin, in particular not as extensive tooling integration (although Grunt, Browserify, Brunch and Gulp is there so far and more is coming). Q: "does ng-annotate have rails assets pipeline integration?" A: "not currently, but hopefully very soon". It should be a 30 minute job for a rails/ruby/gem savvy person to create it.

[kikonen-fiksu]

Thx, I may try to take peek on this assets integ.

[olov]

@kikonen this discussion does not belong is this thread so let's take it elsewhere (email/twitter/issue). FWIW ng-annotate does not require ES6 because defs, info in BUILD.md

[kikonen]

First draft: https:/kikonen/ngannotate-rails

[ralyodio]

+1

[vincentjr]

+1 :D

[indianazhao]

+1

[didil]

+1

[andredublin]

+1

[turkingj]

+1

[27leaves]

I also switched to ng-annotate about a month ago and haven't looked back.

[bdefore]

+1

[mattupstate]

Would this be a result of ngmin not "supporting" ui-router?

[Error] Error: [$injector:unpr] Unknown provider: aProvider <- a <- $http <- $templateFactory <- $view <- $state
http://errors.angularjs.org/1.2.19/$injector/unpr?p0=aProvider%20%3C-%20a%20%3C-%20%24http%20%3C-%20%24templateFactory%20%3C-%20%24view%20%3C-%20%24state
    (anonymous function) (app.js, line 2)
    c (app.js, line 2)
   ... lots more ...

[eddiemonge]

Please try https:/olov/ng-annotate. ngmin is now deprecated: #93

If your issue isn't resolved there please open an issue at https:/olov/ng-annotate/issues

If you really want ngmin to fix this issue, feel free to fork it and use that.