Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The future of ngmin #70

Closed
mlegenhausen opened this issue Jan 16, 2014 · 4 comments
Closed

The future of ngmin #70

mlegenhausen opened this issue Jan 16, 2014 · 4 comments

Comments

@mlegenhausen
Copy link

I am a little bit worried about ngmin and the further support of the project cause in the last 3 months the only accepted push requests where for readme updates. Getting feedback from @btford for push requests are even more rare.

So what are the plans for the project? Is it time to fork ngmin or is it possible to add more maintainers for the project?

@btford
Copy link
Owner

btford commented Jan 16, 2014

Malte,

Thanks for your concern. I've been working on a rewrite of ngmin to address
some of the broader concerns of existing users that can't be addressed
otherwise. This is taking longer that I'd hoped, but I'm still making
progress.

I'd be happy to add more contributors.

-Brian

On Thu, Jan 16, 2014 at 3:24 AM, Malte Legenhausen <[email protected]

wrote:

I am a little bit worried about ngmin and the further support of the
project cause in the last 3 months the only accepted push requests where
for readme updates. Getting feedback from @btfordhttps:/btfordfor push requests are even more rare.

So what are the plans for the project? Is it time to fork ngmin or is it
possible to add more maintainers for the project?


Reply to this email directly or view it on GitHubhttps://issues/70
.

@mlegenhausen
Copy link
Author

Thanks for your fast reply that sounds good and give hope. It is possible to get some insights in your rewrite? Will it be the same tool as it is yet or are you planing something like your DI annotation from issue #44?

Maybe I can help you out with pull request to complete the list of standard annotations for the angular core modules until your rewrite is ready?

@btford
Copy link
Owner

btford commented Mar 3, 2014

@mlegenhausen it will be the same tool.

The problem is that it's impossible to construct a finite list for annotations via static analysis.

@eddiemonge
Copy link
Collaborator

Please try https:/olov/ng-annotate. ngmin is now deprecated: #93

If your issue isn't resolved there please open an issue at https:/olov/ng-annotate/issues

If you really want ngmin to fix this issue, feel free to fork it and use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants