Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Conformance] Expand valid email tests to cover semi-valid email address values #136

Closed
rodaine opened this issue Nov 29, 2023 · 0 comments · Fixed by #163
Closed

[Conformance] Expand valid email tests to cover semi-valid email address values #136

rodaine opened this issue Nov 29, 2023 · 0 comments · Fixed by #163
Labels
Conformance Related to the conformance testing cases or harness Feature New feature or request Good First Issue Good issues for first-time contributors

Comments

@rodaine
Copy link
Member

rodaine commented Nov 29, 2023

If implementations of the isEmail custom CEL expression use an address parsing library, the input might contain extraneous whitespace that the parser automatically cleans (e.g., " [email protected] ".isEmail() might evaluate to true). This goes against the spirit of the field.string.email constraint. We should add similar conformance tests that cover these cases (a'la the fix for this bug in protovalidate-go).
@rodaine rodaine added Feature New feature or request Good First Issue Good issues for first-time contributors Conformance Related to the conformance testing cases or harness labels Nov 29, 2023
@rodaine rodaine linked a pull request Feb 15, 2024 that will close this issue
Add conformance tests for email addresses to cover semi-valid email a… #163
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Conformance Related to the conformance testing cases or harness Feature New feature or request Good First Issue Good issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add conformance tests for email addresses to cover semi-valid email a… arun1587/protovalidate
1 participant
@rodaine