Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance tests for email addresses to cover semi-valid email a… #163

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

arun1587
Copy link
Contributor

…ddresses

PR to add emailSuite to the GlobalSuites that shall be used by the conformance tests.
the suite includes a valid email case and multiple invalid cases (spaced padded, <> enclosed addresses)

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2024

CLA assistant check
All committers have signed the CLA.

@rodaine
Copy link
Member

rodaine commented Feb 12, 2024

Thanks for the patch, @arun1587! We really want these tests to target the buf.validate.field.string.email standard constraint alongside the existing email tests. Internally, it uses that CEL function, so we verify both at the same time.

Copy link
Member

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@rodaine rodaine merged commit cd64fa3 into bufbuild:main Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Conformance] Expand valid email tests to cover semi-valid email address values
3 participants