Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-LAdvapi32.lib in buildfile #19

Closed
boris-kolpackov opened this issue Jun 9, 2023 · 0 comments · Fixed by #21
Closed

-LAdvapi32.lib in buildfile #19

boris-kolpackov opened this issue Jun 9, 2023 · 0 comments · Fixed by #21

Comments

@boris-kolpackov
Copy link

Noticed this error in the submitted 1.11.0 in queue:

error: relative -L directory 'Advapi32.lib\' in '-LC:\\install\\lib -lspdlog -LAdvapi32.lib -lfmt'
  info: while parsing pkg-config --libs C:\install\lib\pkgconfig\libspdlog.shared.pc
  info: while applying rule cxx.link to configure updating build-installed-bpkg\spdlog-tests-1.11.0\spdlog-tests\exe{driver}
  info: while applying rule config.alias to configure updating build-installed-bpkg\spdlog-tests-1.11.0\dir{spdlog-tests\}
  info: while applying rule config.alias to configure updating build-installed-bpkg\dir{spdlog-tests-1.11.0\}

Which I think is caused by this broke fragment in buildfile:

cxx.libs += -LAdvapi32.lib
lib{spdlog}: cxx.export.libs += -LAdvapi32.lib

Should probably be:

cxx.libs += -ladvapi32
lib{spdlog}: cxx.export.libs += -ladvapi32

I am going to push 1.11.0 to public so if you want to fix this, you will need to release a revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant