Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to spdlog 1.12.0 #20

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Update to spdlog 1.12.0 #20

merged 3 commits into from
Nov 20, 2023

Conversation

helmesjo
Copy link
Contributor

@helmesjo helmesjo commented Nov 18, 2023 •
edited
Loading

  • Changes package versions to 1.12.0-a.0.z.
  • Updates upstream/ to v1.12.0.
  • Updates fmt to ^10.1.1.

@helmesjo helmesjo requested review from Wmbat and Klaim November 18, 2023 17:55
@Klaim
Copy link
Collaborator

Klaim commented Nov 18, 2023

Before merging this, I just noticed #19 , I was not notified of that issue and @Wmbat doesnt seem to be available these days, so it would be best to do this fix, release a revision of 1.11.0 and then base this PR on that fix.
I'll try to do it soon but can't guarantee when yet.

@Klaim
Copy link
Collaborator

Klaim commented Nov 18, 2023

Meanwhile, LGTM, except the version name which is set to alpha, I'm not sure why?

@helmesjo
Copy link
Contributor Author

Meanwhile, LGTM, except the version name which is set to alpha, I'm not sure why?

Figured once it is merged we'll just do a bdep release. Didn't want to have tags created before it was merged.
If I'm not mistaken bdep wants it to be a snapshot when running the release command?

@Klaim
Copy link
Collaborator

Klaim commented Nov 19, 2023

Meanwhile, LGTM, except the version name which is set to alpha, I'm not sure why?

Figured once it is merged we'll just do a bdep release. Didn't want to have tags created before it was merged. If I'm not mistaken bdep wants it to be a snapshot when running the release command?

Yes it's ok to not have a tag and indeed ideally the tag should be created jsut before publishing.
But you dont need to tag if you know the version of upstream already and want to be able to adjust before tagging,
so you can set the proper version in the manifest, send to bdep ci as much as you want and iterate from that.
Then when it's looking good, you bdep release --tag --push so that the release commit and the tag gets created and pushed on the repo. Then you publish that version through bdep publish.
At least that's what I usually do.

But no problem if you want to wait for the release to switch to non-alpha, I guess it's leading to the same result.

@helmesjo
Copy link
Contributor Author

helmesjo commented Nov 20, 2023 •
edited
Loading

Alright, thanks for the explanation. Then I'll keep it as is then you/me can just release & publish once it's merged.

Speaking of CI:
https://ci.stage.build2.org/@1c546498-6536-4bb4-8d74-707b56a4452f

@helmesjo helmesjo mentioned this pull request Nov 20, 2023
Merged
@helmesjo
Copy link
Contributor Author

helmesjo commented Nov 20, 2023 •
edited
Loading

Queued a new build after rebasing on main (with #21):
https://ci.stage.build2.org/@a5efcd34-6b24-4ee0-a79b-d36c1060c371

Klaim
Klaim approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@helmesjo helmesjo changed the title Release 1.12.0 Update to spdlog 1.12.0 Nov 20, 2023
@helmesjo helmesjo merged commit 277084b into main Nov 20, 2023
@helmesjo helmesjo deleted the release-1.12.0 branch November 20, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaim Klaim Klaim approved these changes

@Wmbat Wmbat Awaiting requested review from Wmbat

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helmesjo @Klaim