Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Firely library #1

Closed
3 tasks done
ruimendesM opened this issue May 29, 2022 · 3 comments
Closed
3 tasks done

Revamp Firely library #1

ruimendesM opened this issue May 29, 2022 · 3 comments
Assignees

Comments

@ruimendesM
Copy link
Contributor

ruimendesM commented May 29, 2022

Goal

On the new app we want to be able to integrate remote configs on the project.
Firely is a library done to help manage remote configs and A/B tests, however currently Firely library is completely outdated.
We want to bring it back to include these functionalities on the new app.

Description

  • Convert current codebase to Kotlin
  • Update outdated firebase dependencies
  • Create a Circle CI pipeline for the library
    - [ ] (Bonus point) Investigate if it could make sense to have it in a Kotlin multiplatform library.
@filipebrandao filipebrandao self-assigned this May 30, 2022
@filipebrandao
Copy link
Contributor

Leaving a note for the future:

Firebase now allows to download a json file with all the Remote Configs keys and default values. Similar to firely-config.json but less structured. Maybe it would be nicer to just use the Firebase json file insted of having to recreate everything in our firely-config.json.

Only disadvantage is that we would loose access to the remote configs through :
FirelyConfig.FeatureFlag.FEATURE_FLAG_1, FirelyConfig.Config.SOME_CONFIG, FirelyConfig.Experiment.MY_EXPERIMENT
And instead it would be just:
FirelyConfig.FEATURE_FLAG_1, FirelyConfig.SOME_CONFIG, FirelyConfig.MY_EXPERIMENT

Basically, saves us work a bit of work but it's less structured.

@filipebrandao
Copy link
Contributor

Some worries about making this lib multiplatform :

@ruimendesM ruimendesM self-assigned this Sep 12, 2022
@ruimendesM
Copy link
Contributor Author

Task done and CI pipeline merged as part of #6 .
Next steps will be to publish both the gradle plugin (being done on #7) and the library later.

Based on the comments from @filipebrandao, we decided to discard the possibility of making this lib multiplatform at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants