Chore/1 revamp #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing firebase dependency in the library module Fixing firely-config.json lookup paths Updating Firebase integration to match the current method: - Firebase initialization - Setting up a google-services.json which are needed nowadays - Updating Firebase method calls which don't exist in their SDK anymore Updating README
Updating README Minor updated
ruimendesM
reviewed
Jun 3, 2022
|
|
||
| public interface ICodeBranch { | ||
| void execute(); | ||
| fun interface ICodeBranch { |
There was a problem hiding this comment.
fun interface.. nice touch 🦾
ruimendesM
approved these changes
Jun 3, 2022
| return mName; | ||
| val view = findViewById<View>(R.id.text_view) as TextView | ||
| view.visibility = if (featureFlag.get()) View.VISIBLE else View.INVISIBLE | ||
| view.text = textXp.get() |
There was a problem hiding this comment.
No ViewBinding? 😢 (I know it is just a sample.. so it is ok 😄 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles #1
Description
build.gradlethough)