-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doc-handling): Some investigations to use documents in the REST … #2976
Merged
johnBgood
merged 9 commits into
epic-1748-doc-ref-handling
from
853-test-mock-file-upload-for-the-rest-connector
Sep 4, 2024
Merged
feat(doc-handling): Some investigations to use documents in the REST … #2976
johnBgood
merged 9 commits into
epic-1748-doc-ref-handling
from
853-test-mock-file-upload-for-the-rest-connector
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
commented
Jul 26, 2024
connector-sdk/core/src/main/java/io/camunda/connector/api/document/BasicDocument.java
Outdated
Show resolved
Hide resolved
johnBgood
commented
Jul 26, 2024
connector-sdk/core/src/main/java/io/camunda/connector/api/document/DocumentStore.java
Outdated
Show resolved
Hide resolved
johnBgood
commented
Jul 26, 2024
...ava/io/camunda/connector/http/base/client/apache/builder/parts/ApacheRequestBodyBuilder.java
Outdated
Show resolved
Hide resolved
...ava/io/camunda/connector/http/base/client/apache/builder/parts/ApacheRequestBodyBuilder.java
Fixed
Show fixed
Hide fixed
chillleader
force-pushed
the
epic-1748-doc-ref-handling
branch
from
August 7, 2024 19:37
381da62
to
541fa7b
Compare
johnBgood
force-pushed
the
853-test-mock-file-upload-for-the-rest-connector
branch
from
August 20, 2024 11:35
9b78cb4
to
4013946
Compare
...ava/io/camunda/connector/http/base/client/apache/builder/parts/ApacheRequestBodyBuilder.java
Dismissed
Show dismissed
Hide dismissed
johnBgood
force-pushed
the
853-test-mock-file-upload-for-the-rest-connector
branch
from
August 23, 2024 07:16
4013946
to
5d8ebc1
Compare
johnBgood
commented
Aug 26, 2024
...ectors/http/http-base/src/main/java/io/camunda/connector/http/base/utils/DocumentHelper.java
Show resolved
Hide resolved
chillleader
force-pushed
the
epic-1748-doc-ref-handling
branch
from
August 29, 2024 12:19
a61e842
to
5299575
Compare
johnBgood
force-pushed
the
853-test-mock-file-upload-for-the-rest-connector
branch
from
August 29, 2024 15:01
706af04
to
5127256
Compare
chillleader
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🙌
...c/main/java/io/camunda/connector/runtime/outbound/OutboundConnectorRuntimeConfiguration.java
Outdated
Show resolved
Hide resolved
...ectors/http/http-base/src/main/java/io/camunda/connector/http/base/utils/DocumentHelper.java
Outdated
Show resolved
Hide resolved
johnBgood
deleted the
853-test-mock-file-upload-for-the-rest-connector
branch
September 4, 2024 09:54
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* feat(sdk): first iteration of document support * apply review suggestions * feat(document): document deserialization & serialization (#3066) * wip (cherry picked from commit a57e940) * wip (cherry picked from commit 5634aea) * prepare end-to-end draft (cherry picked from commit 92ec79f) * prepare end-to-end draft (cherry picked from commit 5a808bd) * rework deserializers (cherry picked from commit 0b0a558) * incorporate feedback, move jackson code into a separate module * clean up accidental change * naming adjustments * lint * remove extra dollar sign * remove extra dollar sign * feat(document): restructure the project and move document stuff to a different package (#3149) * refactor: move document stuff to a different module --------- Co-authored-by: Jonathan Roques <[email protected]> * fix(document): document serializer doesn't handle sdk document model (#3205) * feat(doc-handling): Some investigations to use documents in the REST … (#2976) * feat(doc-handling): Some investigations to use documents in the REST connector --------- Co-authored-by: Pavel Kotelevsky <[email protected]> Co-authored-by: Pavel Kotelevsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for documents in the REST Connector.
We can now access a document from the store by its id, and send it using this connector.
We can't put document in the store for now (will be done soon).