fix(document): handle SDK document reference correctly in the serializer #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* feat(sdk): first iteration of document support * apply review suggestions * feat(document): document deserialization & serialization (#3066) * wip (cherry picked from commit a57e940) * wip (cherry picked from commit 5634aea) * prepare end-to-end draft (cherry picked from commit 92ec79f) * prepare end-to-end draft (cherry picked from commit 5a808bd) * rework deserializers (cherry picked from commit 0b0a558) * incorporate feedback, move jackson code into a separate module * clean up accidental change * naming adjustments * lint * remove extra dollar sign * remove extra dollar sign * feat(document): restructure the project and move document stuff to a different package (#3149) * refactor: move document stuff to a different module --------- Co-authored-by: Jonathan Roques <[email protected]> * fix(document): document serializer doesn't handle sdk document model (#3205) * feat(doc-handling): Some investigations to use documents in the REST … (#2976) * feat(doc-handling): Some investigations to use documents in the REST connector --------- Co-authored-by: Pavel Kotelevsky <[email protected]> Co-authored-by: Pavel Kotelevsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug because of which document references from the connector context were not serialized correctly.