Skip to content

Commit

Permalink
Merge #3462
Browse files Browse the repository at this point in the history
3462: Try increasing the epoch length in integration tests r=Anviking a=Anviking

- [x] Try doubling the epoch length from 80 slots to 160 slots, and also double k

### Comments

In #3461 we are seeing wallets having trouble syncing at all. It seems there isn't even a valid chain. A pool must produce a block within 3k/f = previously 75 slots
from genesis or the chain will be broken, with "NoLedgerView" being a symptom.
(https://input-output-rnd.slack.com/archives/CR599HMFX/p1649430846682959?thread_ts=1649430803.174879&cid=CR599HMFX)

We do see TraceNoLedgerView in the logs of the CI failures:

```
[pool-1:cardano.node.Forge:Error:34] [2022-08-25 09:29:47.00 UTC] fromList [("credentials",String "Cardano"),("val",Object (fromList [("kind",String "TraceNoLedgerView"),("slot",Number 30.0)]))]
[pool-1:cardano.node.LeadershipCheck:Info:34] [2022-08-25 09:29:47.20 UTC] {"chainDensity":0,"credentials":"Cardano","delegMapSize":4,"kind":"TraceStartLeadershipCheck","slot":31,"utxoSize":5263}
[pool-1:cardano.node.Forge:Error:34] [2022-08-25 09:29:47.20 UTC] fromList [("credentials",String "Cardano"),("val",Object (fromList [("kind",String "TraceNoLedgerView"),("slot",Number 31.0)]))]
```

/however/ the first TraceNoLedgerView we see is at slot 30, well before
slot 75.

Regardless, this commit increases the epoch length in hope that it might
alleviate the issue.

Changing the epochLength /could/ lead to other problems, but e.g.
`waitForNextEpoch` should still work correctly with a 90s timeout
waiting at most for 32s, so hopefully we're good.

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

ADP-2171 / #3461

<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->


Co-authored-by: Johannes Lund <[email protected]>
  • Loading branch information
iohk-bors[bot] and Anviking authored Aug 25, 2022
2 parents 974ffe0 + 3576e74 commit 6b1344b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lib/core-integration/src/Test/Integration/Framework/DSL.hs
Original file line number Diff line number Diff line change
Expand Up @@ -712,11 +712,11 @@ slotLengthValue = 0.2

-- | Parameter in test cluster shelley genesis.
securityParameterValue :: Word32
securityParameterValue = 5
securityParameterValue = 10

-- | Parameter in test cluster shelley genesis.
epochLengthValue :: Word32
epochLengthValue = 80
epochLengthValue = 160

-- | Wallet server's chosen transaction TTL value (in seconds) when none is
-- given.
Expand Down
4 changes: 2 additions & 2 deletions lib/shelley/src/Cardano/Wallet/Shelley/Launch/Cluster.hs
Original file line number Diff line number Diff line change
Expand Up @@ -933,8 +933,8 @@ generateGenesis dir systemStart initialFunds addPoolsToGenesis = do
{ sgSystemStart = systemStart'
, sgActiveSlotsCoeff = unsafePositiveUnitInterval 0.5
, sgSlotLength = 0.2
, sgSecurityParam = 5
, sgEpochLength = 80
, sgSecurityParam = 10
, sgEpochLength = 160
, sgUpdateQuorum = 1
, sgNetworkMagic = 764824073
, sgSlotsPerKESPeriod = 86400
Expand Down

0 comments on commit 6b1344b

Please sign in to comment.