Try increasing the epoch length in integration tests #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #3461 we are seeing the cluster setup fail. It seems the chain gets broken. A pool must produce a block within 3k/f = previously 75 slots or the chain will be broken, with "NoLedgerView" being a symptom. (https://input-output-rnd.slack.com/archives/CR599HMFX/p1649430846682959?thread_ts=1649430803.174879&cid=CR599HMFX) We do see TraceNoLedgerView in the logs of the CI failures: [pool-1:cardano.node.Forge:Error:34] [2022-08-25 09:29:47.00 UTC] fromList [("credentials",String "Cardano"),("val",Object (fromList [("kind",String "TraceNoLedgerView"),("slot",Number 30.0)]))] [pool-1:cardano.node.LeadershipCheck:Info:34] [2022-08-25 09:29:47.20 UTC] {"chainDensity":0,"credentials":"Cardano","delegMapSize":4,"kind":"TraceStartLeadershipCheck","slot":31,"utxoSize":5263} [pool-1:cardano.node.Forge:Error:34] [2022-08-25 09:29:47.20 UTC] fromList [("credentials",String "Cardano"),("val",Object (fromList [("kind",String "TraceNoLedgerView"),("slot",Number 31.0)]))] /however/ the first TraceNoLedgerView we see is at slot 30, well before slot 75. Regardless, this commit increases the epoch length in hope that it might alleviate the issue. Changing the epochLength /could/ lead to other problems, but e.g. `waitForNextEpoch` should still work correctly with a 90s timeout waiting at most for 32s, so hopefully we're good.
|
bors try |
tryBuild succeeded: |
|
bors try |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 25, 2022
3462: Try increasing the epoch length in integration tests r=Anviking a=Anviking - [x] Try doubling the epoch length from 80 slots to 160 slots, and also double k ### Comments In #3461 we are seeing wallets having trouble syncing at all. It seems there isn't even a valid chain. A pool must produce a block within 3k/f = previously 75 slots from genesis or the chain will be broken, with "NoLedgerView" being a symptom. (https://input-output-rnd.slack.com/archives/CR599HMFX/p1649430846682959?thread_ts=1649430803.174879&cid=CR599HMFX) We do see TraceNoLedgerView in the logs of the CI failures: ``` [pool-1:cardano.node.Forge:Error:34] [2022-08-25 09:29:47.00 UTC] fromList [("credentials",String "Cardano"),("val",Object (fromList [("kind",String "TraceNoLedgerView"),("slot",Number 30.0)]))] [pool-1:cardano.node.LeadershipCheck:Info:34] [2022-08-25 09:29:47.20 UTC] {"chainDensity":0,"credentials":"Cardano","delegMapSize":4,"kind":"TraceStartLeadershipCheck","slot":31,"utxoSize":5263} [pool-1:cardano.node.Forge:Error:34] [2022-08-25 09:29:47.20 UTC] fromList [("credentials",String "Cardano"),("val",Object (fromList [("kind",String "TraceNoLedgerView"),("slot",Number 31.0)]))] ``` /however/ the first TraceNoLedgerView we see is at slot 30, well before slot 75. Regardless, this commit increases the epoch length in hope that it might alleviate the issue. Changing the epochLength /could/ lead to other problems, but e.g. `waitForNextEpoch` should still work correctly with a 90s timeout waiting at most for 32s, so hopefully we're good. <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number ADP-2171 / #3461 <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Co-authored-by: Johannes Lund <[email protected]>
tryBuild succeeded: |
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
In #3461 we are seeing wallets having trouble syncing at all. It seems there isn't even a valid chain. A pool must produce a block within 3k/f = previously 75 slots
from genesis or the chain will be broken, with "NoLedgerView" being a symptom.
(https://input-output-rnd.slack.com/archives/CR599HMFX/p1649430846682959?thread_ts=1649430803.174879&cid=CR599HMFX)
We do see TraceNoLedgerView in the logs of the CI failures:
/however/ the first TraceNoLedgerView we see is at slot 30, well before
slot 75.
Regardless, this commit increases the epoch length in hope that it might
alleviate the issue.
Changing the epochLength /could/ lead to other problems, but e.g.
waitForNextEpochshould still work correctly with a 90s timeoutwaiting at most for 32s, so hopefully we're good.
Issue Number
ADP-2171 / #3461