Mark LoggingSpec pending on macOS to alleviate timeouts #2709

Anviking · 2021-06-11T19:08:26Z

Issue Number

ADP-970

Overview

Mark LoggingSpec pending on macOS

Anviking · 2021-06-11T19:12:01Z

bors try

iohk-bors · 2021-06-11T20:06:00Z

try

Build succeeded:

rvl

I originally thought we should remove the entire spec as you have done, but then @piotr-iohk reminded me that there are some useful tests such as those checking that sensitive data is not logged.

If it's a problem only on macOS but not at all on Linux, then that's a possible concern, and we should investigate a little bit.

Otherwise, how about adding a pendingOnMacOS function to Test.Utils? And/or removing the worst-offending tests, if there are such tests?

This might help reduce the unit test timeouts on macOS hydra builds. Investigating #2472 Jonathan found the following tests to fail with limited ulimit -v: 36% Match String: "Checkpoint" 44% Match String: "correct time measures" 100% Match String: "different request ids" 20% Match String: "Private Key" 32% Match String: "Tx History" 28% Match String: "Wallet Metadata" where entries 2 and 3 are from LogginsSpec. The timeouts in CI were in these following locations: 12 times (28%) 000000 // from "Not Allowed Methods" 9 times (21%) Checkpoint 8 times (19%) rollback 5 times (12%) 8601 // from e.g. "ISO 8601 extended format without timezones" 4 times (9%) JSON 4 times (9%) MVar 4 times (9%) readStakeDistribution // only in the past, so now fixed 1 times (2%) Coverage which either suggest there are an 10+ lines of output not shown in the output, or the LoggingSpec isn't to blame. So it would be very interesting to see whether this commit reduces timeouts or not.

Anviking · 2021-06-14T11:26:19Z

bors try

Anviking · 2021-06-14T11:36:10Z

Otherwise, how about adding a pendingOnMacOS function to Test.Utils?

Done.

worst-offending tests, if there are such tests?

I think @jonathanknowles's investigation would suggest the properties are the worst-offending tests, but this is not at all clear from the CI logs. I marked the whole of LoggingSpec pending on macOS to be sure. (If we see that this reduces timeouts, we could try un-mark some of them later.)

Anviking · 2021-06-14T12:33:57Z

bors r+

2709: Mark LoggingSpec pending on macOS to alleviate timeouts r=Anviking a=Anviking # Issue Number  ADP-970 # Overview  - [x] Mark LoggingSpec pending on macOS Co-authored-by: Johannes Lund <[email protected]>

Anviking · 2021-06-14T12:39:16Z

https://hydra.iohk.io/build/6660598
Another non-unit test timeout - probably related to this

deleting '/nix/store/30jzd3cxgvnwh90230cdppl32r6kil63-lsp-lib-lsp-1.2.0.0'
deleting '/nix/store/j7j4886753kp7gx5sm7z3gi20x643v4k-lsp-lib-lsp-1.2.0.0-ghc-8.10.5-env'
deleting '/nix/store/hncwhl41ayjr1ln0naqzm4kq531w5rv5-lsp-lib-lsp-1.2.0.0-config'
deleting '/nix/store/0k501d4bn65zz2mw2xw6vcf2ypsg136k-lsp-types-lib-lsp-types-1.2.0.0-ghc-8.10.5-env'
deleting '/nix/store/5l9b69fimjzcqknrmwi1jxnbw0lmc987-lsp-types-lib-lsp-types-1.2.0.0'
deleted or invalidated more than 20024074240 bytes; stopping
deleting '/nix/store/trash'
error (ignored): chmod '/nix/store/trash/vwsf9k289lk5gl5kxbs067cd7iib1vrv-hls-brittany-plugin-lib-hls-brittany-plugin-1.0.0.1-ghc-8.10.5-env/exactDeps/ghc-boot-th': No such file or directory
building of '/nix/store/p148a9y1sjn71zxqc3q0xpj10in2vy21-cardano-wallet-core-lib-cardano-wallet-core-2021.6.11' timed out after 900 seconds of silence

iohk-bors · 2021-06-14T13:53:25Z

Build failed:

ci/hydra-build:required

     POST /wallets/0000000000000000000000000000000000000000/utxo
     PATCH /wallets/0000000000000000000000000000000000000000/utxo
     DELETE /wallets/0000000000000000000000000000000000000000/utxo
     CONNECT /wallets/0000000000000000000000000000000000000000/utxo
     TRACE /wallets/0000000000000000000000000000000000000000/utxo
     OPTIONS /wallets/0000000000000000000000000000000000000000/utxo
Cardano.Wallet.DB.MVar
  MVar
    Extra Properties about DB initialization
building of '/nix/store/4zqiijx4m80ng6sgmcchcnfjzm76415j-cardano-wallet-core-test-unit-2021.6.11-check' timed out after 900 seconds of silence

#2472 (macOS)

iohk-bors · 2021-06-14T14:26:14Z

try

Build failed:

ci/hydra-build:required

Anviking · 2021-06-14T20:57:01Z

bors r+

2709: Mark LoggingSpec pending on macOS to alleviate timeouts r=Anviking a=Anviking # Issue Number  ADP-970 # Overview  - [x] Mark LoggingSpec pending on macOS Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2021-06-14T21:20:22Z

Build failed:

ci/hydra-build:required

  CONNECT /wallets/0000000000000000000000000000000000000000/transactions/0000000000000000000000000000000000000000000000000000000000000000
     TRACE /wallets/0000000000000000000000000000000000000000/transactions/0000000000000000000000000000000000000000000000000000000000000000
     OPTIONS /wallets/0000000000000000000000000000000000000000/transactions/0000000000000000000000000000000000000000000000000000000000000000
     PUT /wallets/0000000000000000000000000000000000000000/utxo
     POST /wallets/0000000000000000000000000000000000000000/utxo
     PATCH /wallets/0000000000000000000000000000000000000000/utxo
     DELETE /wallets/0000000000000000000000000000000000000000/utxo
     CONNECT /wallets/0000000000000000000000000000000000000000/utxo
     TRACE /wallets/0000000000000000000000000000000000000000/utxo
     OPTIONS /wallets/0000000000000000000000000000000000000000/utxo
Cardano.Wallet.DB.MVar
  MVar
    Extra Properties about DB initialization
building of '/nix/store/czslwg0i71q5j3jsmfga13aph1dqv0rm-cardano-wallet-core-test-unit-2021.6.11-check' timed out after 900 seconds of silence

#2472

Anviking · 2021-06-15T10:46:52Z

bors r+

2709: Mark LoggingSpec pending on macOS to alleviate timeouts r=Anviking a=Anviking # Issue Number  ADP-970 # Overview  - [x] Mark LoggingSpec pending on macOS Co-authored-by: Johannes Lund <[email protected]>

iohk-bors · 2021-06-15T11:17:35Z

Build failed:

buildkite/cardano-wallet

Completed 8 action(s).
--
&nbsp; | /tmp/stack-cec31295fc21ac5c/test-ghc-env: openBinaryFile: resource busy (file is locked)
&nbsp; | &nbsp;
&nbsp; | /tmp/stack-cec31295fc21ac5c/test-ghc-env: openBinaryFile: resource busy (file is locked)
&nbsp; | &nbsp;
&nbsp; | /tmp/stack-cec31295fc21ac5c/test-ghc-env: openBinaryFile: resource busy (file is locked)
&nbsp; | error: Command exited with code 1!
&nbsp; | Continuing...

#2657

Anviking · 2021-06-15T11:58:29Z

bors r+

iohk-bors · 2021-06-15T12:30:13Z

Build succeeded:

Anviking force-pushed the anviking/ADP-970/rm-LoggingSpec branch from c795177 to 5e271a5 Compare June 11, 2021 19:09

Anviking self-assigned this Jun 11, 2021

iohk-bors bot added a commit that referenced this pull request Jun 11, 2021

Try #2709:

eb4bb13

rvl suggested changes Jun 13, 2021

View reviewed changes

Anviking force-pushed the anviking/ADP-970/rm-LoggingSpec branch 2 times, most recently from fc2c57a to d2e8268 Compare June 14, 2021 10:39

Anviking changed the title ~~Try removing LoggingSpec to alleviate macOS unit timeouts~~ Mark LoggingSpec pending on macOS to alleviate timeouts Jun 14, 2021

Anviking force-pushed the anviking/ADP-970/rm-LoggingSpec branch from d2e8268 to b5a55db Compare June 14, 2021 10:43

Anviking added 2 commits June 14, 2021 12:44

Add pendingOnMacOS helper

e629dcf

Anviking force-pushed the anviking/ADP-970/rm-LoggingSpec branch from b5a55db to 127d785 Compare June 14, 2021 10:44

iohk-bors bot added a commit that referenced this pull request Jun 14, 2021

Try #2709:

17ad358

Anviking requested a review from rvl June 14, 2021 11:36

rvl approved these changes Jun 14, 2021

View reviewed changes

iohk-bors bot merged commit a080bd0 into master Jun 15, 2021

iohk-bors bot deleted the anviking/ADP-970/rm-LoggingSpec branch June 15, 2021 12:30

jonathanknowles mentioned this pull request Jun 16, 2021

Reduce the number of concurrent request threads in middleware tests. #2717

Closed

Anviking mentioned this pull request Jun 22, 2021

Set -j 1 in macOS nix unit tests #2727

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark LoggingSpec pending on macOS to alleviate timeouts #2709

Mark LoggingSpec pending on macOS to alleviate timeouts #2709

Anviking commented Jun 11, 2021 •

edited

Loading

Anviking commented Jun 11, 2021

iohk-bors bot commented Jun 11, 2021

rvl left a comment

Anviking commented Jun 14, 2021

Anviking commented Jun 14, 2021 •

edited

Loading

Anviking commented Jun 14, 2021

Anviking commented Jun 14, 2021 •

edited

Loading

iohk-bors bot commented Jun 14, 2021 •

edited by Anviking

Loading

iohk-bors bot commented Jun 14, 2021

Anviking commented Jun 14, 2021

iohk-bors bot commented Jun 14, 2021 •

edited by Anviking

Loading

Anviking commented Jun 15, 2021

iohk-bors bot commented Jun 15, 2021 •

edited by Anviking

Loading

Anviking commented Jun 15, 2021

iohk-bors bot commented Jun 15, 2021

Mark LoggingSpec pending on macOS to alleviate timeouts #2709

Mark LoggingSpec pending on macOS to alleviate timeouts #2709

Conversation

Anviking commented Jun 11, 2021 • edited Loading

Issue Number

Overview

Anviking commented Jun 11, 2021

iohk-bors bot commented Jun 11, 2021

try

rvl left a comment

Choose a reason for hiding this comment

Anviking commented Jun 14, 2021

Anviking commented Jun 14, 2021 • edited Loading

Anviking commented Jun 14, 2021

Anviking commented Jun 14, 2021 • edited Loading

iohk-bors bot commented Jun 14, 2021 • edited by Anviking Loading

iohk-bors bot commented Jun 14, 2021

try

Anviking commented Jun 14, 2021

iohk-bors bot commented Jun 14, 2021 • edited by Anviking Loading

Anviking commented Jun 15, 2021

iohk-bors bot commented Jun 15, 2021 • edited by Anviking Loading

Anviking commented Jun 15, 2021

iohk-bors bot commented Jun 15, 2021

Anviking commented Jun 11, 2021 •

edited

Loading

Anviking commented Jun 14, 2021 •

edited

Loading

Anviking commented Jun 14, 2021 •

edited

Loading

iohk-bors bot commented Jun 14, 2021 •

edited by Anviking

Loading

iohk-bors bot commented Jun 14, 2021 •

edited by Anviking

Loading

iohk-bors bot commented Jun 15, 2021 •

edited by Anviking

Loading