Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the waterfall request details, Early Hints are breaking on commas #2248

Closed
scottjehl opened this issue Aug 8, 2022 · 0 comments · Fixed by #2275
Closed

In the waterfall request details, Early Hints are breaking on commas #2248

scottjehl opened this issue Aug 8, 2022 · 0 comments · Fixed by #2275
Assignees
@tkadlec
Labels
Type: Bug An issue or pull request relating to a bug in WebPageTest

Comments

@scottjehl
Copy link
Contributor

The commas in hints end up causing new list items in our early hint formatter.
@scottjehl scottjehl added the Type: Bug An issue or pull request relating to a bug in WebPageTest label Aug 8, 2022
tkadlec added a commit that referenced this issue Aug 17, 2022
@tkadlec
Previously, we were splitting the early_hint_headers by comma (,). Bu…
a93c25a 
…t in situations where comma's were used in the URL specified, that broke display.

This commit instead splits the headers by using a positive lookahead matching the '<' character. That way the '<' is still included in the individual strings. Then we strip out the last character for each hint if that character is a comma, just for cleanliness. This fixes #2248"
@tkadlec tkadlec mentioned this issue Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkadlec tkadlec

Labels
Type: Bug An issue or pull request relating to a bug in WebPageTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the issue with early hints display when comma's are in the URLs catchpoint/WebPageTest
2 participants
@tkadlec @scottjehl