Fix the issue with early hints display when comma's are in the URLs #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in situations where comma's were used in the URL specified, that broke display. This commit instead splits the headers by using a positive lookahead matching the '<' character. That way the '<' is still included in the individual strings. Then we strip out the last character for each hint if that character is a comma, just for cleanliness. This fixes #2248"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were splitting the early_hint_headers by comma
,. But in situations where comma's were used in the URL specified, that broke display.This commit instead splits the headers by using a positive lookahead matching the
<character. That way the<is still included in the individual strings. Then we strip out the last character for each hint if that character is a comma, just for cleanliness. This fixes #2248