Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveness sidecar to ceph csi drivers #1096

Open
humblec opened this issue May 22, 2020 · 14 comments
Open

Add liveness sidecar to ceph csi drivers #1096

humblec opened this issue May 22, 2020 · 14 comments
Assignees
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs keepalive This label can be used to disable stale bot activiity in the repo

Comments

@humblec
Copy link
Collaborator

humblec commented May 22, 2020

The CSI livenessprobe is a sidecar container that monitors the health of the CSI driver and reports it to Kubernetes via the Liveness Probe mechanism. This enables Kubernetes to automatically detect issues with the driver and restart the pod to try and fix the issue.

@humblec humblec self-assigned this May 22, 2020
@humblec humblec added this to the release-3.0.0 milestone May 22, 2020
@humblec
Copy link
Collaborator Author

humblec commented May 22, 2020

@Madhu-1 fyi

@nixpanic nixpanic added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label May 25, 2020
@mykaul
Copy link
Contributor

mykaul commented May 27, 2020

What is an unhealthy CSI driver? How we define it? Are there are any metrics we can use?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 27, 2020

What is an unhealthy CSI driver? How we define it? Are there are any metrics we can use?

if the CSI driver is not sending any response to the GRPC request sent by liveness container it will be treated as unhealthy

how to use liveness is here https:/kubernetes-csi/livenessprobe#usage

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 27, 2020

@humblec as we already have a liveness container which is built as part of ceph-csi can we expose an endpoint and use the same or do we need to use k8s-csi liveness

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 20, 2020

@humblec do we need it in release-3.0.0 milestone? or can we move it outside

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 24, 2020

Moving it to release-v3.1.0

@Madhu-1 Madhu-1 modified the milestones: release-3.0.0, release-3.1.0 Jul 24, 2020
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 6, 2020

@humblec can this be done in 3.1.0? or do we need to move it out to the next release?

@humblec humblec removed this from the release-3.1.0 milestone Aug 10, 2020
@humblec
Copy link
Collaborator Author

humblec commented Sep 29, 2020

@Yuggupta27 interested to work on this ?

@pkalever
Copy link

@humblec, I think @Yuggupta27 is busy with CI/e2e stuff, I'm happy to take over.

@Yuggupta27 feel free to jump in :-)

Thanks!

@Madhu-1 Madhu-1 assigned pkalever and unassigned humblec and Yuggupta27 Sep 29, 2020
pkalever pushed a commit to pkalever/ceph-csi that referenced this issue Nov 4, 2020
The health status liveness probe shares and runs within the
liveness-prometheus container. The health status liveness probe
listen and serve requests at a dedicated port and path. By default
they listen at '/healthz' path and '9680' port, which can be
easily configurable.

Fixes: ceph#1096
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever pushed a commit to pkalever/ceph-csi that referenced this issue Nov 6, 2020
The health status liveness probe shares and runs within the
liveness-prometheus container. The health status liveness probe
listen and serve requests at a dedicated port and path. By default
they listen at '/healthz' path and '9680' port, which can be
easily configurable.

Fixes: ceph#1096
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
@rjbrown57
Copy link

Any Updates on this?

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 21, 2021
@github-actions
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@Rakshith-R Rakshith-R removed the wontfix This will not be worked on label Sep 13, 2021
@Rakshith-R Rakshith-R added the keepalive This label can be used to disable stale bot activiity in the repo label Sep 13, 2021
@Rakshith-R Rakshith-R reopened this Sep 13, 2021
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 12, 2023

This can be reworked using kubernetes/enhancements#2727

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jun 6, 2024

This can be reworked using kubernetes/enhancements#2727

This currently works for GRPC server with port not with socket, we need to see if its possible or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs keepalive This label can be used to disable stale bot activiity in the repo
Projects
None yet
8 participants