Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support liveness probe configure in kubernetes yaml #4482

Closed
1 task
yylt opened this issue Mar 8, 2024 · 3 comments
Closed
1 task

support liveness probe configure in kubernetes yaml #4482

yylt opened this issue Mar 8, 2024 · 3 comments

Comments

@yylt
Copy link

yylt commented Mar 8, 2024

Describe the feature you'd like to have

When the liveness check fails, the container should be restarted. Currently, the failure of the check can only be determined through the /metrics path with csi_liveness as shown below:

$ curl 10.46.1.6:8680/metrics|more
# HELP csi_liveness Liveness Probe
# TYPE csi_liveness gauge
csi_liveness 0

This is not very friendly for pod probe checks in Kubernetes. A common way to check pods is through the following method:

livenessProbe:
  httpGet:
    host: 127.0.0.1
    path: /healthz
    port: 8080
    scheme: HTTP
  failureThreshold: 8
  initialDelaySeconds: 15
  periodSeconds: 10
  successThreshold: 1
  timeoutSeconds: 15

Could you provide an endpoint for liveness to facilitate probe checks?

What is the value to the end user? (why is it a priority?)

When a health check fails, the container can be restarted instead of showing as running but not being able to do anything.

How will we know we have a good solution? (acceptance criteria)

  • add new healthz endpoint, like /healthz
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Mar 12, 2024

@yylt is this duplicate of #1096?

@yylt
Copy link
Author

yylt commented Mar 13, 2024

Yes, it is indeed repetitive, there is no PR of #1096.

Additionally, could consider using the https:/kubernetes-csi/livenessprobe project replace?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Mar 13, 2024

Yes i have mentioned different options in #1096, considering it am closing this as duplicate, Thank you

@Madhu-1 Madhu-1 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants