Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harm: move dga domain classification to other #1992

Merged
1 commit merged into from
Jun 17, 2021
Merged

harm: move dga domain classification to other #1992

1 commit merged into from
Jun 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 16, 2021

move "dga domain" to the taxonomy other, as it is not accepted in RSIT
rename to "dga-domain" to match the name scheme of other types
adapt bots depending on the name
add changelog and news entries, including SQL update statements

@ghost ghost added the data-format label Jun 16, 2021
@ghost ghost added this to the 3.0.0 milestone Jun 16, 2021
@ghost ghost requested a review from waldbauer-certat June 16, 2021 19:15
@ghost ghost self-assigned this Jun 16, 2021
@ghost ghost mentioned this pull request Jun 16, 2021
16 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #1992 (dc3615d) into develop (2190345) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1992   +/-   ##
========================================
  Coverage    75.86%   75.86%           
========================================
  Files          416      416           
  Lines        22232    22235    +3     
  Branches      2940     2941    +1     
========================================
+ Hits         16866    16869    +3     
  Misses        4690     4690           
  Partials       676      676           
Impacted Files Coverage Δ
intelmq/bots/experts/idea/expert.py 98.07% <ø> (ø)
intelmq/bots/experts/taxonomy/expert.py 100.00% <ø> (ø)
intelmq/tests/bots/parsers/bambenek/test_parser.py 100.00% <ø> (ø)
intelmq/bots/parsers/bambenek/parser.py 94.11% <100.00%> (ø)
intelmq/lib/harmonization.py 87.59% <100.00%> (+0.03%) ⬆️
intelmq/tests/lib/test_harmonization.py 100.00% <100.00%> (ø)

move "dga domain" to the taxonomy other, as it is not accepted in RSIT
rename to "dga-domain" to match the name scheme of other types
adapt bots depending on the name
add changelog and news entries, including SQL update statements
@ghost ghost merged commit cf58860 into develop Jun 17, 2021
@ghost ghost mentioned this pull request Jun 17, 2021
@ghost ghost deleted the class-dga branch June 21, 2021 07:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants