Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harm: rename compromised to system-compromise #1993

Merged
1 commit merged into from
Jun 17, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2021

match with RSIT in the taxonomy intrusions:
compromised -> system-compromise
unauthorized-command -> system-compromise
unauthorized-login -> system-compromise
adapt bots depending on the name
add changelog and news entries, including SQL update statements

based on #1992 to prevent merge conflicts

@ghost ghost added the data-format label Jun 17, 2021
@ghost ghost added this to the 3.0.0 milestone Jun 17, 2021
@ghost ghost requested a review from waldbauer-certat June 17, 2021 08:18
@ghost ghost self-assigned this Jun 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #1993 (c307df4) into develop (277f72d) will increase coverage by 0.00%.
The diff coverage is 73.68%.

@@           Coverage Diff            @@
##           develop    #1993   +/-   ##
========================================
  Coverage    75.86%   75.87%           
========================================
  Files          416      416           
  Lines        22235    22244    +9     
  Branches      2941     2944    +3     
========================================
+ Hits         16869    16878    +9     
  Misses        4690     4690           
  Partials       676      676           
Impacted Files Coverage Δ
intelmq/bots/experts/idea/expert.py 98.07% <ø> (ø)
intelmq/bots/experts/taxonomy/expert.py 100.00% <ø> (ø)
intelmq/bots/parsers/cert_eu/parser_csv.py 82.00% <ø> (ø)
intelmq/bots/parsers/cymru/parser_cap_program.py 64.70% <0.00%> (ø)
intelmq/bots/parsers/misp/parser.py 88.23% <ø> (ø)
intelmq/bots/parsers/spamhaus/parser_cert.py 83.46% <0.00%> (ø)
...telmq/tests/bots/parsers/cznic/test_parser_haas.py 90.47% <ø> (ø)
intelmq/tests/bots/parsers/dyn/test_parser.py 100.00% <ø> (ø)
...s/parsers/shadowserver/test_compromised_website.py 100.00% <ø> (ø)
...ts/bots/parsers/shadowserver/test_scan_exchange.py 90.47% <ø> (ø)
... and 7 more

@ghost ghost mentioned this pull request Jun 17, 2021
16 tasks
@ghost ghost added the component: core label Jun 17, 2021
@ghost ghost mentioned this pull request Jun 17, 2021
match with RSIT in the taxonomy intrusions:
compromised -> system-compromise
unauthorized-command -> system-compromise
unauthorized-login -> system-compromise
 adapt bots depending on the name
add changelog and news entries, including SQL update statements
@ghost ghost force-pushed the class-system-compromise branch from 9d77e87 to c307df4 Compare June 17, 2021 11:56
@ghost
Copy link
Author

ghost commented Jun 17, 2021

rebased on develop

@ghost ghost merged commit 28abba8 into develop Jun 17, 2021
@ghost ghost deleted the class-system-compromise branch June 21, 2021 07:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants