Deprecations 3.0 #1997
Merged
Deprecations 3.0 #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 17, 2021 18:22
the arguments given by pipeline_args were not effective, as the load_configuration methods of the pipeline classes still tried to access the parameters at self. also modify the tests to catch a bug like this in the future fixes #1875
was renamed and marked as deprecated in 2.0.0.beta1 #1404
The command `e` for deleting single entries by given IDs has been merged into the command `d` ("delete"), which can now delete either entries by ID or the whole file.
The command `v` for editing entries has been renamed to `e` ("edit").
Compatibility with the deprecated configuration format (before 1.0.0.dev7) was removed. #1404
ghost
added this to the 
ghost
requested a review
from
added 4 commits
June 17, 2021 19:39
compatibility with the deprecated parameter `unzip_attachment` (removed in 2.1.0) was removed. #1404
the init contained a fallback method if a parameter does not exist this is no longer necessary, as all bots have proper default values related to #1404
create_request_session_from_bot was deprecated and is no longer used #1404
The deprecated shell scripts - `update-asn-data` - `update-geoip-data` - `update-tor-nodes` - `update-rfiprisk-data` have been removed in favor of the built-in update-mechanisms (see the bots' documentation). A crontab file for calling all new update command can be found in `contrib/cron-jobs/intelmq-update-database`. #1404
Codecov Report
@@ Coverage Diff @@
## develop #1997 +/- ##
===========================================
+ Coverage 75.91% 75.94% +0.02%
===========================================
Files 418 417 -1
Lines 22364 22337 -27
Branches 2970 2967 -3
===========================================
- Hits 16978 16963 -15
+ Misses 4700 4690 -10
+ Partials 686 684 -2
|
waldbauer-certat
approved these changes
Jun 20, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for more details
fixes #1404