cleanup: Remove AUTORET macro and clean up PassField overrides #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't use decltype(auto) everywhere because it doesn't seem to work in SFINAE contexts. Substitution failure leads to compile errors instead of just silently dropping functions from overload set.
Since decltype(auto) doesn't works inside SFINAE context, need to replace enable_if<output.init()> with enable_if<output.get()>
Need to use decltype(expression) instead of decltype(auto) for get() methods, because they are used in SFINAE contexts to detect whether function arguments are input or output arguments. For output-only arguments, getParams().getXXX() method won't exist, so get method shouldn't be declared. For input-only arguments, getResult().getXXX() method won't exist, so get method shouldn't be declared.
This override is useful for other count(0) parameters, not just ThreadMap, so no reason it needs to be specific to ThreadMap. This commit follows up earlier commit cleaning up and unifying PassField functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #46.
AUTORETmacro is no longer needed with C++14decltype(auto)