Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove AUTORET macro and clean up PassField overrides #64

Merged
merged 5 commits into from
Dec 31, 2021
Merged

cleanup: Remove AUTORET macro and clean up PassField overrides #64

merged 5 commits into from
Dec 31, 2021

Commits on Dec 31, 2021

  1. Replace AUTO_RETURN uses with decltype(auto) 

    Can't use decltype(auto) everywhere because it doesn't seem to work in
SFINAE contexts. Substitution failure leads to compile errors instead of
just silently dropping functions from overload set.
    @ryanofsky
    ryanofsky committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    ea1a77b View commit details
    Browse the repository at this point in the history

  2. Replace output.init AUTO_RETURN uses with decltype(auto) 

    Since decltype(auto) doesn't works inside SFINAE context, need to
replace enable_if<output.init()> with enable_if<output.get()>
    @ryanofsky
    ryanofsky committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    1d00505 View commit details
    Browse the repository at this point in the history

  3. Consolidate PassField function to remove AUTO_RETURN uses

    @ryanofsky
    ryanofsky committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    41db49c View commit details
    Browse the repository at this point in the history

  4. Inline last AUTO_RETURN uses and remove macro 

    Need to use decltype(expression) instead of decltype(auto) for get()
methods, because they are used in SFINAE contexts to detect whether
function arguments are input or output arguments.  For output-only
arguments, getParams().getXXX() method won't exist, so get method
shouldn't be declared. For input-only arguments, getResult().getXXX()
method won't exist, so get method shouldn't be declared.
    @ryanofsky
    ryanofsky committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    3f388cf View commit details
    Browse the repository at this point in the history

  5. Replace ThreadMap Passfield override with generic count(0) override 

    This override is useful for other count(0) parameters, not just
ThreadMap, so no reason it needs to be specific to ThreadMap.

This commit follows up earlier commit cleaning up and unifying PassField
functions.
    @ryanofsky
    ryanofsky committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    cf7ebfe View commit details
    Browse the repository at this point in the history