Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: suppress warning for tabula-py generated java_options #358

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

chezou
Copy link
Owner

@chezou chezou commented Sep 10, 2023

Description

Follow up for #357

Motivation and Context

tabula-py generated java_options can be ignored for jpype warning.

How Has This Been Tested?

Manual test.

Before

$  .venv/bin/python -m timeit  'import tabula; tabula.read_pdf_with_template("examples/data.pdf", "examples/data.tabula-template.json")'
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
java_options is ignored until rebooting the Python process.
1 loop, best of 5: 59.1 msec per loop

After

$ .venv/bin/python -m timeit  'import tabula; tabula.read_pdf_with_template("examples/data.pdf", "examples/data.tabula-template.json")'
1 loop, best of 5: 57.3 msec per loop

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read the contributing document.
  • My code follows the code style of this project with running linter.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chezou chezou merged commit 9bde1e5 into master Sep 10, 2023
2 checks passed
@chezou chezou deleted the reduce-warning branch September 10, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant