Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: suppress warning for tabula-py generated java_options #358

Merged
merged 1 commit into from
Sep 10, 2023
Merged

chore: suppress warning for tabula-py generated java_options #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tabula/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,18 @@ def _run(
options, as well as an optional path to pass to tabula-java as a regular
argument to use for any required output sent to stderr.
"""
# Ignore some options that are set by tabula-py
IGNORED_JAVA_OPTIONS = {
"-Djava.awt.headless=true",
"-Dfile.encoding=UTF8",
"-Dorg.slf4j.simpleLogger.defaultLogLevel=off",
"-Dorg.apache.commons.logging.Log=org.apache.commons.logging.impl.NoOpLog",
}

global _tabula_vm
if not _tabula_vm:
_tabula_vm = TabulaVm(java_options, options.silent)
elif java_options:
elif set(java_options) - IGNORED_JAVA_OPTIONS:
logger.warning("java_options is ignored until rebooting the Python process.")

return _tabula_vm.call_tabula_java(options, path)
Expand Down