Install all uhdm related headers in flat $PREFIX/include/uhdm/*.h #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... we'll only get this in once the previous change #487 is in again. |
This removes the arbitrary distinction between relatively meaningless names header/ and include/ Adapt all code that used the previous paths in their includes to point to the new location. Install location is presumed to be a 'system location', i.e. the includes are used in angled brackets, such as #include <uhdm/uhdm.h> This likely cause one-time disruption for current users, but currently the user-base is small enough to be a limited disruption. While at it, install also the UHDM.capnp in $PREFIX/lib/uhdm for other tools using different languages to pick up just the schema. Fixes #484 Signed-off-by: Henner Zeller <[email protected]>
|
Once this is merged, I have another change that then updates Surelog to use the new includes (e.g. But till then, merge this into UHDM (so that I can refer to head in the Surelog change), but do not update submodule in Surelog alone (as that will not compile without the other change) |
kamilrakoczy
pushed a commit
to antmicro/yosys-f4pga-plugins
that referenced
this pull request
Oct 29, 2021
Since the following PRs chipsalliance/UHDM#488 chipsalliance/Surelog#1827 ... the new location of uhdm headers is prefixed with uhdm, such as <uhdm/foo.h> Signed-off-by: Henner Zeller <[email protected]>
tjurtsch
pushed a commit
to antmicro/yosys-f4pga-plugins
that referenced
this pull request
Oct 29, 2021
Since the following PRs chipsalliance/UHDM#488 chipsalliance/Surelog#1827 ... the new location of uhdm headers is prefixed with uhdm, such as <uhdm/foo.h> Signed-off-by: Henner Zeller <[email protected]>
kbieganski
pushed a commit
to antmicro/yosys-f4pga-plugins
that referenced
this pull request
Oct 29, 2021
Since the following PRs chipsalliance/UHDM#488 chipsalliance/Surelog#1827 ... the new location of uhdm headers is prefixed with uhdm, such as <uhdm/foo.h> Signed-off-by: Henner Zeller <[email protected]>
kgugala
pushed a commit
to antmicro/yosys-f4pga-plugins
that referenced
this pull request
Oct 29, 2021
Since the following PRs chipsalliance/UHDM#488 chipsalliance/Surelog#1827 ... the new location of uhdm headers is prefixed with uhdm, such as <uhdm/foo.h> Signed-off-by: Henner Zeller <[email protected]>
tpagarani
pushed a commit
to tpagarani/yosys-symbiflow-plugins
that referenced
this pull request
Dec 7, 2021
Since the following PRs chipsalliance/UHDM#488 chipsalliance/Surelog#1827 ... the new location of uhdm headers is prefixed with uhdm, such as <uhdm/foo.h> Signed-off-by: Henner Zeller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE INTO SURELOG YET
This removes the arbitrary distinction between relatively
meaningless names header/ and include/
Adapt all code that used the previous paths in their includes
to point to the new location.
Install location is presumed to be a 'system location', i.e. the distributed includes are used in angled brackets,
such as
#include <uhdm/uhdm.h>This likely cause one-time disruption for current users that directly included things from
uhdm/headers/foo.has these are now inuhdm/foo.h; currently the user-base is small enough to be a limited disruption.While at it, install also the UHDM.capnp in
$PREFIX/lib/uhdmfor other tools using different languages to pick up just the
schema.
Fixes #484
Signed-off-by: Henner Zeller [email protected]