-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECC] missing reduction operation on hashed message #221
Labels
bug
Something isn't working
Comments
The fix has been implemented as follows, and a set of test vectors (with message greater than q) has been added to ecc testbench to verify this.
|
#240 sync fixed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To sign or verify a message, the input hash must be reduced modulo q, as specified in RFC6979 page 9. This step was missing in the ECC implementation and caused a discrepancy with the HMAC_DRBG output. This error was not detected by our random tests because the chance of getting a random number larger than q is very low.
We need to add a new test vector with a message that exceeds q to verify this step.
The text was updated successfully, but these errors were encountered: