Merge dev-integrate -> main #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal-tag: [#47908]
Reintegrate main -> dev-public
Add test for Mailbox JTAG accesses with clock gating
Reintegrate main -> dev-msft
…error injection sequence Adjust wait methodology when pausing the rand reg access routine to avoid errant termination of the task and subsequent deadlock Related work items: #584641
Added some interleaved operations like writes to random clients during debug/scan modes, after clear/locks, etc. Earlier, only a few of the clients were being exercised. Added a task to randomly select a combination of write clients Related work items: #586448
…ce condition * In UVM validation firmware for caliptra_top, fix the mbox_unlock procedure so internal firmware interrupts in the data structure are cleared before asserting mbox_unlock. This allows subsequent errors immediately after the unlock to trigger a whole new error handling flow instead of being masked. Related work items: #585880
Add SV assertions to uvmf_caliptra_top testbench Related work items: #586843
* Remove TODO comments from the top portlist in caliptra_top * Resolves #284 * Fix uvmf_caliptra_top compilation with the iTRNG option by including the UVMF_CALIPTRA_TOP define (for SVA usage). * Add generated UVM compilation file lists (.vf) * The compilation file lists should provide clarity regarding #265 Related work items: #587032, #587095
Dev msft 20231110
Internal-Tag: [#51338] Signed-off-by: Maciej Kurc <[email protected]>
Merge dev-msft -> dev-integrate
calebofearth
requested review from
Nitsirks,
andreslagarcavilla,
bharatpillilli,
mcockrell-google and
howardtr
Nitsirks
previously approved these changes
Nov 14, 2023
|
This sync is predominantly populated with updates to the file list (.vf) files, for minor whitespace adjustments and to provide UVM compilation lists. EDIT: additional changes have been added to this PR, with 2 more RTL modifications:
|
bharatpillilli
previously approved these changes
Nov 14, 2023
mcockrell-google
previously approved these changes
Nov 14, 2023
|
Currently blocked until #298 completes |
calebofearth
dismissed stale reviews from mcockrell-google, bharatpillilli, and Nitsirks
via
4a89cff
Fix failing mailbox access test
Internal-Tag: [#51306] Signed-off-by: Maciej Kurc <[email protected]>
Internal-Tag: [#51306] Signed-off-by: Maciej Kurc <[email protected]>
Remove read IDCODE instruction from VeeR JTAG TAP
* Update VCS steps with instructions to copy test vector generator * Add Makefile VCS sim step to copy test vector gen scripts * Add steps for running UVM unit tests * VCS instructions for running unit tests
) Internal-Tag: [#51415] Signed-off-by: Maciej Kurc <[email protected]>
…nternal Manual filesystem merge from GH repo (Bringing back to GH to include some file modifications - lic headers) Related work items: #587660
Addresses regression failures due to test setup issue and last dword clear logic Related work items: #588795
Migrate our synthesis setup to fusion compiler NOTE: MSFT internal synthesis flow is used as a pipe-cleaner to check for synthesizability, lint, timing. This may be different from tools used by other Caliptra developers for more rigorous physical analysis. Related work items: #589061
…tall Fix three different regression errors caused by testbench bugs: * An edge case can cause AHB interface to stall up to 34 clock cycles when running SHA accelerator operations, previous TB code flags an error above 33 clock cycles * A multi-threaded sequence issue in the soc_ifc mailbox testcase with random register access injection can result in deadlock * A false-positive test pass might be reported for Caliptra-initiated mailbox tests - erroneous/unexpected MBOX_ERROR transitions are handled normally, even for non-error-injection scenarios. Related work items: #589323, #589324, #589546
Update lower level scan mode sequence to make debugUnlock input to KV a pulse instead of a level Add some helpful prints to predictor Related work items: #591177
* Fix the GH issue #295, which describes a scenario where ECC errors on reads from ICCM may not trigger the error signal and cause cptra_error_fatal to assert. * Fix a minor UVM issue in uvmf_soc_ifc that causes intermittent errors during nightly regression. Related work items: #597603, #597604, #597607
Dev msft 20231130
Merge dev-msft -> dev-integrate
Merge dev-public -> dev-integrate
calebofearth
requested review from
steven-bellock,
mcockrell-google,
Nitsirks and
bharatpillilli
bharatpillilli
approved these changes
Dec 1, 2023
Nitsirks
approved these changes
Dec 1, 2023
|
@andreslagarcavilla or @bharatpillilli can you complete this PR to main? It is ready to go. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #284
Resolves #295
Resolves #289