Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Integration Specification with clarifying language #405

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Update Integration Specification with clarifying language #405

merged 9 commits into from
Feb 15, 2024

Conversation

calebofearth
Copy link
Collaborator

@calebofearth calebofearth commented Feb 2, 2024 •
edited
Loading

Add language explaining that SoC is responsible for initializing SRAM to 0 during a powergood cycle.
Update language around PAUSER integration requirements in table.
Add clarity to requirements for GENERIC_INPUT_WIRES stating that unused bits must be tied to 0.

@calebofearth calebofearth added the documentation Improvements or additions to documentation label Feb 2, 2024
@calebofearth calebofearth self-assigned this Feb 2, 2024
pkwidzin-amd
pkwidzin-amd previously approved these changes Feb 2, 2024
View reviewed changes
steph-morton
steph-morton previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@steph-morton steph-morton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor (ok if out of scope): could lowercase "threat" in "Caliptra Threat model" to align with most of the usage in the table

@calebofearth
Copy link
Collaborator Author

minor (ok if out of scope): could lowercase "threat" in "Caliptra Threat model" to align with most of the usage in the table

Went ahead and made this change, thanks

varuns-nvidia
varuns-nvidia previously approved these changes Feb 2, 2024
View reviewed changes
varuns-nvidia
varuns-nvidia previously approved these changes Feb 2, 2024
View reviewed changes
@calebofearth calebofearth changed the title Update Integration Specification with clarifying language for SRAM initialization. Update Integration Specification with clarifying language Feb 2, 2024
varuns-nvidia
varuns-nvidia previously approved these changes Feb 2, 2024
View reviewed changes
@calebofearth
Copy link
Collaborator Author

This PR is ready to complete - @andreslagarcavilla or @bharatpillilli, can you merge when we have the requisite reviews?

@bharatpillilli bharatpillilli merged commit 9536d99 into main Feb 15, 2024
47 checks passed
@calebofearth calebofearth deleted the cwhitehead_v1.0_spec_updates branch February 15, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steph-morton steph-morton steph-morton approved these changes

@bharatpillilli bharatpillilli bharatpillilli approved these changes

@andreslagarcavilla andreslagarcavilla Awaiting requested review from andreslagarcavilla

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd

@Nitsirks Nitsirks Awaiting requested review from Nitsirks

@korran korran Awaiting requested review from korran

@mhatrevi mhatrevi Awaiting requested review from mhatrevi

@varuns-nvidia varuns-nvidia Awaiting requested review from varuns-nvidia

@pkwidzin-amd pkwidzin-amd Awaiting requested review from pkwidzin-amd

Assignees

@calebofearth calebofearth

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calebofearth @bharatpillilli @pkwidzin-amd @varuns-nvidia @steph-morton