Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new matchers #538

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Added new matchers #538

merged 4 commits into from
Jun 25, 2020

Conversation

slinkydeveloper
Copy link
Member

@slinkydeveloper slinkydeveloper commented Jun 24, 2020 •
edited
Loading

  • AnyOf
  • DataContains
  • ContainsExactlyExtensions
  • HasExactlyAttributesEqualTo

Signed-off-by: Francesco Guardiani [email protected]

@slinkydeveloper
Added AnyOf and DataContains matchers
4672d44 
Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Jun 24, 2020
@slinkydeveloper slinkydeveloper added this to the SDK 2.1 milestone Jun 24, 2020
@slinkydeveloper
Added ContainsExactlyExtensions matcher
9dc7c4d 
Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper slinkydeveloper changed the title Added AnyOf and DataContains matchers Added AnyOf, DataContains and ContainsExactlyExtensions matchers Jun 24, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Jun 24, 2020
Merged
@slinkydeveloper
Linter thing
6156c5e 
Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper slinkydeveloper changed the title Added AnyOf, DataContains and ContainsExactlyExtensions matchers Added new matchers Jun 24, 2020
n3wscott
n3wscott approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slinkydeveloper slinkydeveloper merged commit 4e46572 into cloudevents:master Jun 25, 2020
@slinkydeveloper slinkydeveloper deleted the new_matchers branch June 25, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
SDK 2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @n3wscott