Expanded the Channel data plane conformance test #3394

slinkydeveloper · 2020-06-24T08:44:19Z

Signed-off-by: Francesco Guardiani [email protected]

Part of #1845

Proposed Changes

Now it tests the equality of the events received
Removed some assertions from recordevents because Added new matchers cloudevents/sdk-go#538 adds them to sdk-go
Increase verbosity in test failures (now it prints the stack)

Let's wait cloudevents/sdk-go#538 first.

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

matzew · 2020-06-24T11:41:57Z

test/conformance/helpers/channel_message_modes_specversion_helper.go

+ for k := range event.Extensions() {
+ extKeys = append(extKeys, k)
+ }
+ extKeys = append(extKeys, eventingchannel.EventHistory)


mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

…equality of the received event Signed-off-by: Francesco Guardiani <[email protected]>

Signed-off-by: Francesco Guardiani <[email protected]>

slinkydeveloper · 2020-06-25T07:45:10Z

/retest

Signed-off-by: Francesco Guardiani <[email protected]>

slinkydeveloper · 2020-06-25T09:34:18Z

/retest

Signed-off-by: Francesco Guardiani <[email protected]>

slinkydeveloper · 2020-06-25T14:34:34Z

uhm on my machine it passes, not on CI

Signed-off-by: Francesco Guardiani <[email protected]>

knative-test-reporter-robot · 2020-06-25T15:14:40Z

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-integration-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestParallel
test/e2e.TestParallel/Channel-messaging.knative.dev/v1beta1
test/e2e.TestParallel/InMemoryChannel-messaging.knative.dev/v1beta1

Signed-off-by: Francesco Guardiani <[email protected]>

knative-metrics-robot · 2020-06-26T07:26:26Z

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/channel/message_receiver.go	74.1%	73.6%	-0.5

slinkydeveloper · 2020-06-26T08:14:57Z

/check-cla

lionelvillard · 2020-06-26T13:38:17Z

@googlebot rescan

slinkydeveloper · 2020-06-26T13:44:28Z

It works!

vaikas · 2020-06-26T17:07:01Z

test/e2e/helpers/parallel_test_helper.go

@@ -136,7 +139,7 @@ func ParallelTestHelper(t *testing.T,
 // verify the logger service receives the correct transformed event
 eventTracker.AssertExact(1, recordevents.MatchEvent(
 HasSource(eventSource),
- recordevents.DataContains(tc.expected),
+ DataContains(tc.expected),


Not your doing, but I'm curious about the conformance test having an exactly once delivery semantics.

vaikas · 2020-06-26T17:08:09Z

go.mod

@@ -4,7 +4,7 @@ go 1.14

 require (
 contrib.go.opencensus.io/exporter/stackdriver v0.13.1 // indirect
- github.com/cloudevents/sdk-go/v2 v2.0.1-0.20200608152019-2ab697c8fc0b
+ github.com/cloudevents/sdk-go/v2 v2.0.1-0.20200625144206-4e4657232c9e


Does this include the 538 fix?

checked and it does :) Thanks!

vaikas · 2020-06-26T17:09:10Z

/lgtm
/approve

knative-prow-robot · 2020-06-26T17:09:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Expanded the channel_message_modes_specversion_helper.go to test the equality of the received event Signed-off-by: Francesco Guardiani <[email protected]> * Linter thing Signed-off-by: Francesco Guardiani <[email protected]> * Fixed types in extensions Signed-off-by: Francesco Guardiani <[email protected]> * Temporary check Signed-off-by: Francesco Guardiani <[email protected]> * Matchers Signed-off-by: Francesco Guardiani <[email protected]> * Removed the wrong time defaulting Signed-off-by: Francesco Guardiani <[email protected]> * Removed time now Signed-off-by: Francesco Guardiani <[email protected]> * Removed time now Signed-off-by: Francesco Guardiani <[email protected]> * Print error stacktrace Signed-off-by: Francesco Guardiani <[email protected]> * More stacktrace print Signed-off-by: Francesco Guardiani <[email protected]> * Updated sdk-go to latest master Signed-off-by: Francesco Guardiani <[email protected]> * Now filterevents is happy Signed-off-by: Francesco Guardiani <[email protected]>

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2020

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 24, 2020

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jun 24, 2020

knative-prow-robot requested review from chizhg and yt3liu June 24, 2020 08:44

mattmoor reviewed Jun 24, 2020

View reviewed changes

matzew reviewed Jun 24, 2020

View reviewed changes

mattmoor reviewed Jun 24, 2020

View reviewed changes

slinkydeveloper added 6 commits June 25, 2020 09:30

Expanded the channel_message_modes_specversion_helper.go to test the …

8ab33dc

…equality of the received event Signed-off-by: Francesco Guardiani <[email protected]>

Linter thing

1a88459

Signed-off-by: Francesco Guardiani <[email protected]>

Fixed types in extensions

b2a5e0a

Signed-off-by: Francesco Guardiani <[email protected]>

Temporary check

ff7daed

Signed-off-by: Francesco Guardiani <[email protected]>

Matchers

ed2950f

Signed-off-by: Francesco Guardiani <[email protected]>

Removed the wrong time defaulting

5386166

Signed-off-by: Francesco Guardiani <[email protected]>

slinkydeveloper force-pushed the expand_message_test_channel branch from cad09f0 to 5386166 Compare June 25, 2020 07:30

slinkydeveloper added 2 commits June 25, 2020 10:23

Removed time now

a9924aa

Signed-off-by: Francesco Guardiani <[email protected]>

Removed time now

08ce42f

Signed-off-by: Francesco Guardiani <[email protected]>

slinkydeveloper added 2 commits June 25, 2020 12:52

Print error stacktrace

362728e

Signed-off-by: Francesco Guardiani <[email protected]>

More stacktrace print

04f23ea

Signed-off-by: Francesco Guardiani <[email protected]>

Updated sdk-go to latest master

a72b3d4

Signed-off-by: Francesco Guardiani <[email protected]>

slinkydeveloper changed the title ~~[WIP] Expanded the Channel data plane conformance test~~ Expanded the Channel data plane conformance test Jun 25, 2020

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2020

Now filterevents is happy

6be00c6

Signed-off-by: Francesco Guardiani <[email protected]>

slinkydeveloper mentioned this pull request Jun 26, 2020

Conformance testing for channel data plane #1845

Closed

vaikas reviewed Jun 26, 2020

View reviewed changes

knative-prow-robot assigned vaikas Jun 26, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2020

knative-prow-robot merged commit 00dabbc into knative:master Jun 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expanded the Channel data plane conformance test #3394

Expanded the Channel data plane conformance test #3394

slinkydeveloper commented Jun 24, 2020 •

edited

Loading

mattmoor left a comment

mattmoor left a comment

mattmoor left a comment

matzew Jun 24, 2020

mattmoor left a comment

slinkydeveloper commented Jun 25, 2020

slinkydeveloper commented Jun 25, 2020

slinkydeveloper commented Jun 25, 2020

knative-test-reporter-robot commented Jun 25, 2020

knative-metrics-robot commented Jun 26, 2020

slinkydeveloper commented Jun 26, 2020

lionelvillard commented Jun 26, 2020

slinkydeveloper commented Jun 26, 2020

vaikas Jun 26, 2020

vaikas Jun 26, 2020

vaikas Jun 26, 2020

vaikas commented Jun 26, 2020

knative-prow-robot commented Jun 26, 2020

Expanded the Channel data plane conformance test #3394

Expanded the Channel data plane conformance test #3394

Conversation

slinkydeveloper commented Jun 24, 2020 • edited Loading

Proposed Changes

mattmoor left a comment

Choose a reason for hiding this comment

mattmoor left a comment

Choose a reason for hiding this comment

mattmoor left a comment

Choose a reason for hiding this comment

matzew Jun 24, 2020

Choose a reason for hiding this comment

mattmoor left a comment

Choose a reason for hiding this comment

slinkydeveloper commented Jun 25, 2020

slinkydeveloper commented Jun 25, 2020

slinkydeveloper commented Jun 25, 2020

knative-test-reporter-robot commented Jun 25, 2020

knative-metrics-robot commented Jun 26, 2020

slinkydeveloper commented Jun 26, 2020

lionelvillard commented Jun 26, 2020

slinkydeveloper commented Jun 26, 2020

vaikas Jun 26, 2020

Choose a reason for hiding this comment

vaikas Jun 26, 2020

Choose a reason for hiding this comment

vaikas Jun 26, 2020

Choose a reason for hiding this comment

vaikas commented Jun 26, 2020

knative-prow-robot commented Jun 26, 2020

slinkydeveloper commented Jun 24, 2020 •

edited

Loading