-
Notifications
You must be signed in to change notification settings - Fork 81
Fela Migration #100
Comments
cf-component-page please! |
Please stop merging into master for now. We agree on how to support a "stable" version of cf-ui and work on big changes like this. |
cf-component-label in PR #103 |
Afaik, it should be fine to merge things. Just don't forget to major bump the new components when you are publishing them for the first time. We can still do bug fix releases of older versions. |
Please check out this on our wiki: WWW / JavaScripts / How to update cf-ui components to Fela |
NoteList of all cf-component cross-dependencies (fortunately it's not that common)
This means that for components
we need to be extra careful that they are not broken once released because they will "silently" appear in our projects everywhere where the card, dropdown... etc are used. So keep an extra eye on them and make sure they match our current styles! The rest of components will (or can) be introduced slowly by replacing imports like cf-component-xxx with @cloudflare/cf-component-xxx. That can be even done on instance by instance basis. |
I updated the description directly. Hope that's cool. |
Related-to: cloudflare#100
Related-to: cloudflare#100
The `ModalClose` component uses the `Icon` component so we need to update the snapshots as well as wrapping the `ModalClose` tests in fela context so it can render correctly. Related-to: cloudflare#100
Related-to: cloudflare#100
Migrate the `cf-component-icon` to ship with it's styles implemented using the "css-in-js" framework `fela`. Related-to: cloudflare#100
Hey @tajo I'm probably just dumb and missing something obvious but I can't seem to find what wiki you're referring to. I'd like to look at that documentation. |
@koddsson ok haha, that makes sense. Just interested in how you guys are reconciling existing components with Fela. Looking through your commits on the ones you've converted so far. Implementing something like the |
In order for to track better I've generated a indvidual issue for each of the remaining components to migrate and the a "Fela Migration" milestone so we don't have to manually update this issue :) |
Lets track the migration of these components here. Call out what you're working on and I'll keep this thread up to date.
8 / 33 ( 24% ) complete.
The text was updated successfully, but these errors were encountered: