Skip to content

Commit

Permalink
modal/close: update snapshots
Browse files Browse the repository at this point in the history
The `ModalClose` component uses the `Icon` component so we need to
update the snapshots as well as wrapping the `ModalClose` tests in fela
context so it can render correctly.

Related-to: cloudflare#100
  • Loading branch information
Kristján Oddsson committed May 22, 2017
1 parent 1c63a1b commit 5f8c5f1
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 20 deletions.
8 changes: 2 additions & 6 deletions packages/cf-component-modal/src/ModalClose.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import PropTypes from 'prop-types';
import Icon from 'cf-component-icon';
import Icon from '../../cf-component-icon/src/';

class ModalClose extends React.Component {
render() {
Expand All @@ -14,11 +14,7 @@ class ModalClose extends React.Component {

ModalClose.propTypes = {
onClick: PropTypes.func.isRequired,
label: PropTypes.oneOfType([PropTypes.string, PropTypes.bool])
};

ModalClose.defaultProps = {
label: false
label: PropTypes.string
};

export default ModalClose;
7 changes: 5 additions & 2 deletions packages/cf-component-modal/test/ModalClose.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,18 @@ import React from 'react';
import renderer from 'react-test-renderer';
import { ModalClose } from '../../cf-component-modal/src/index';
import Icon from '../../cf-component-icon/src/index';
import felaTestContext from '../../../felaTestContext';

test('should render', () => {
const component = renderer.create(<ModalClose onClick={() => {}} />);
const component = renderer.create(
felaTestContext(<ModalClose onClick={() => {}} />)
);
expect(component.toJSON()).toMatchSnapshot();
});

test('should render with a label', () => {
const component = renderer.create(
<ModalClose label="label" onClick={() => {}} />
felaTestContext(<ModalClose label="label" onClick={() => {}} />)
);
expect(component.toJSON()).toMatchSnapshot();
});
22 changes: 16 additions & 6 deletions packages/cf-component-modal/test/__snapshots__/ModalClose.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,16 @@ exports[`should render 1`] = `
onClick={[Function]}
>
<i
className="cf-icon cf-icon--close cf-icon--2x"
role={undefined}
/>
className="cf-17bf5fe"
id={undefined}
style={undefined}
>
<span
className="cf-1u9fru1"
id={undefined}
style={undefined}
/>
</i>
</span>
`;

Expand All @@ -18,11 +25,14 @@ exports[`should render with a label 1`] = `
onClick={[Function]}
>
<i
className="cf-icon cf-icon--close cf-icon--2x"
role={undefined}
className="cf-17bf5fe"
id={undefined}
style={undefined}
>
<span
className="cf-icon__label"
className="cf-1u9fru1"
id={undefined}
style={undefined}
>
label
</span>
Expand Down
12 changes: 6 additions & 6 deletions packages/cf-style-provider/test/__snapshots__/index.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -9,33 +9,33 @@ exports[`StyleProvider should render styles 1`] = `
<head>
<style id=\\"stylesheet\\" data-fela-stylesheet=\\"\\">
@-webkit-keyframes k1 {
0% {
from {
transform: rotate(0deg);
-webkit-transform: rotate(0deg)
}
100% {
to {
transform: rotate(359deg);
-webkit-transform: rotate(359deg)
}
}
@-moz-keyframes k1 {
0% {
from {
transform: rotate(0deg);
-webkit-transform: rotate(0deg)
}
100% {
to {
transform: rotate(359deg);
-webkit-transform: rotate(359deg)
}
}
@keyframes k1 {
0% {
from {
transform: rotate(0deg);
-webkit-transform: rotate(0deg)
}
100% {
to {
transform: rotate(359deg);
-webkit-transform: rotate(359deg)
}
Expand Down

0 comments on commit 5f8c5f1

Please sign in to comment.