Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: _worker.js file not in file counter #1599

Closed
thibault-deriv opened this issue Aug 2, 2022 · 2 comments · Fixed by #1671
Closed

🐛 BUG: _worker.js file not in file counter #1599

thibault-deriv opened this issue Aug 2, 2022 · 2 comments · Fixed by #1671
Assignees
Labels
bug Something that isn't working pages:validated A validated Pages issue pages Relating to Pages

Comments

@thibault-deriv
Copy link

What version of Wrangler are you using?

2.0.24

What operating system are you using?

Linux

Describe the Bug

I have a directory with one index.html file, one redirected.html and one _worker.js file like the following:

$ tree
.
├── index.html
├── redirected.html
└── _worker.js

0 directories, 3 files

I'm using wrangler 2.0.24:

$ npx wrangler --version
 ⛅️ wrangler 2.0.24 
--------------------

When I upload the files, _worker.js seems not uploaded Uploading... (2/2) (but it is):

$ CLOUDFLARE_ACCOUNT_ID=d97daaaaaaaabbbbbbbbbcccccccca054 CLOUDFLARE_API_TOKEN=T0k3n npx wrangler pages publish . --project-name=workr --branch=up
🌍  Uploading... (2/2)

✨ Success! Uploaded 0 files (2 already uploaded) (0.25 sec)

✨ Deployment complete! Take a peek over at https://b33be5fd.workr.pages.dev

Same in UI, _worker.js does not appear:
no_worker_ui

Upload via UI

When uploading via UI, you can see the _worker.js well listed during "upload step":
upload_step

But later, as with wrangler, it does not appear in "Deployment details":
ui_no_worker

It's minor... but confusing 😅

@thibault-deriv thibault-deriv added the bug Something that isn't working label Aug 2, 2022
@WalshyDev WalshyDev added the pages Relating to Pages label Aug 2, 2022
@nprogers nprogers added the pages:validated A validated Pages issue label Aug 3, 2022
@nprogers
Copy link
Contributor

nprogers commented Aug 3, 2022

We should add a line in the CLI output indicating that the functions file was uploaded.

@Skye-31 Skye-31 self-assigned this Aug 7, 2022
Skye-31 added a commit that referenced this issue Aug 14, 2022
* feat: pages publish - log special files being uploaded

Closes #1599

* skip flaky test

Co-authored-by: Greg Brimble <[email protected]>
Co-authored-by: Daniel Walsh <[email protected]>
@thibault-deriv
Copy link
Author

Thank you a lot @Skye-31 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working pages:validated A validated Pages issue pages Relating to Pages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants