Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pages publish - log special files being uploaded #1671

Merged
merged 4 commits into from
Aug 14, 2022

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Aug 13, 2022

Closes #1599
Assigning Natalie as she suggested the message.

Had to skip 2 flaky DO tests that were causing it to repetitively fail

@Skye-31 Skye-31 added the pages Relating to Pages label Aug 13, 2022
@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2022

🦋 Changeset detected

Latest commit: b5a235c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2852037159/npm-package-wrangler-1671

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1671/npm-package-wrangler-1671

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2852037159/npm-package-wrangler-1671 dev path/to/script.js

@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #1671 (b5a235c) into main (1b232aa) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
- Coverage   80.94%   80.89%   -0.06%     
==========================================
  Files          91       91              
  Lines        6062     6067       +5     
  Branches     1555     1555              
==========================================
+ Hits         4907     4908       +1     
- Misses       1155     1159       +4     
Impacted Files Coverage Δ
packages/wrangler/src/pages/publish.tsx 43.79% <0.00%> (-1.48%) ⬇️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@Skye-31
Copy link
Contributor Author

Skye-31 commented Aug 13, 2022

Tests keep failing because of the flaky DO test https:/cloudflare/wrangler2/runs/7819000410?check_suite_focus=true#step:6:2701
Have retried a couple of times

@WalshyDev
Copy link
Member

Tests keep failing because of the flaky DO test https:/cloudflare/wrangler2/runs/7819000410?check_suite_focus=true#step:6:2701
Have retried a couple of times

Can we quarantine this for now? It's annoying

@Skye-31 Skye-31 force-pushed the pages-publish-log-special-files branch from d7a954b to 598891a Compare August 13, 2022 12:22
@Skye-31 Skye-31 force-pushed the pages-publish-log-special-files branch from 598891a to b5a235c Compare August 13, 2022 12:49
Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make an issue to track fixing these tests?

LGTM pending Jacob's go ahead

@Skye-31 Skye-31 merged commit 808c0ab into main Aug 14, 2022
@Skye-31 Skye-31 deleted the pages-publish-log-special-files branch August 14, 2022 13:26
This was referenced Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: _worker.js file not in file counter
5 participants