Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Container overflow constrained to the content slot #2864

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Oct 14, 2024

Description

Fixes scrollable area in container which affects the placement of table sticky scrollbar.

Rel: AWSUI-54814

How has this been tested?

  • New integ test
  • Screenshot tests
  • Dry-run
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (4220993) to head (54e9b8c).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
- Coverage   96.20%   96.20%   -0.01%     
==========================================
  Files         761      761              
  Lines       21453    21453              
  Branches     6944     6944              
==========================================
- Hits        20639    20638       -1     
- Misses        806      807       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot marked this pull request as ready for review October 16, 2024 14:14
@pan-kot pan-kot requested a review from a team as a code owner October 16, 2024 14:14
@pan-kot pan-kot requested review from michaeldowseza and removed request for a team October 16, 2024 14:14
@pan-kot pan-kot added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 11df6c3 Oct 18, 2024
39 checks passed
@pan-kot pan-kot deleted the fix-table-sticky-scrollbar branch October 18, 2024 11:58
pan-kot added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants