Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Container overflow constrained to the content slot (#2864) #2907

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Oct 21, 2024

This reverts commit 11df6c3.

Description

Reverting because of impact on the dashboard demos that need to be resolved first.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot marked this pull request as ready for review October 21, 2024 12:27
@pan-kot pan-kot requested a review from a team as a code owner October 21, 2024 12:27
@pan-kot pan-kot requested review from gethinwebster and removed request for a team October 21, 2024 12:27
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (01aecc9) to head (1de4122).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2907   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         761      761           
  Lines       21530    21530           
  Branches     7308     7362   +54     
=======================================
  Hits        20715    20715           
- Misses        762      807   +45     
+ Partials       53        8   -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 4014103 Oct 21, 2024
38 checks passed
@pan-kot pan-kot deleted the revert-container-paddings branch October 21, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants