BUG: Mark translatable strings in Applications folder #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lassoan
force-pushed
the
mark-applications
branch
from
3310e4a
to
82571da
Compare
The comments happened to start with colon, which Qt lupdate tool interpreted as translator comments without any translatable strings nearby. This threw warnings during text extraction. Fixed by removing the commented-out code (that should not have been left there anyway).
Log messages should not be translated (it is not intended for users and would make it harder for developers to interpret the logs).
lassoan
approved these changes
Apr 5, 2023
lassoan
force-pushed
the
mark-applications
branch
from
d56c869
to
b6c829e
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see Slicer/SlicerLanguagePacks#17
see Slicer/SlicerLanguagePacks#12