solve internationalization problems when using ctk dicom widget with languages other than english #813
Conversation
…ith languages other than english
…languages other than english
There was a problem hiding this comment.
Another request: it would be good to add working internationalization to the demo app for ctkDICOM. So some translation files that would work with these changes would also be needed. That way people will know that this feature exists and that it doesn't break the existing functionality.
| query->setHost(parameters["Address"].toString()); | ||
| query->setPort(parameters["Port"].toInt()); | ||
| query->setPreferCGET(parameters["CGET"].toBool()); | ||
| query->setCalledAETitle(parameters[QApplication::translate("ctkDICOMServerNodeWidget", "AETitle", 0)].toString()); |
There was a problem hiding this comment.
Can we make this simpler with just tr("AETITLE") ?
There was a problem hiding this comment.
ok,i will add the translation files to the demo app.
I use tr at first, but it seems can't work well. I will try again
There was a problem hiding this comment.
after test, I have found that tr() will set the context with wrong one, it will cause the translation file can not be used. so i still use QApplication::translate
| @@ -57,7 +59,10 @@ class ctkDICOMTableViewPrivate : public Ui_ctkDICOMTableView | |||
| QStringList currentSelection; | |||
| //Key = QString for columns, Values = QStringList | |||
| QHash<QString, QStringList> sqlWhereConditions; | |||
|
|
|||
| private: | |||
| QLabel lblqueryTableName; | |||
There was a problem hiding this comment.
Better to match naming conventions, so this could be: labelQueryTableName
| for(int i = 0; i < dicomSQLModel.columnCount(); i++) | ||
| { | ||
| QVariant fieldName = dicomSQLModel.headerData(i, Qt::Horizontal, Qt::DisplayRole); | ||
| QString headerText = QApplication::translate("ctkDICOMTableView", fieldName.toString().toStdString().c_str(), 0); |
There was a problem hiding this comment.
ok, I use sublime text to modify the code, so the indentation is strange, I will modify it .
| @@ -226,7 +250,15 @@ void ctkDICOMTableView::setDicomDataBase(ctkDICOMDatabase *dicomDatabase) | |||
| void ctkDICOMTableView::setQueryTableName(const QString &tableName) | |||
| { | |||
| Q_D(ctkDICOMTableView); | |||
| d->lblTableName->setText(tableName); | |||
| //d->lblTableName->setText(tableName); | |||
| @@ -146,7 +155,22 @@ void ctkDICOMTableViewPrivate::hideUIDColumns() | |||
| //---------------------------------------------------------------------------- | |||
| QString ctkDICOMTableViewPrivate::queryTableName() const | |||
| { | |||
| return this->lblTableName->text(); | |||
| //return this->lblTableName->text(); | |||
There was a problem hiding this comment.
STYLE: remove dead code
STYLE: change to labelTableName (I see this was already there and you were being consistent but it would be good clean this up while we are working on this code)
|
@pieper request changes have been modified |
…nalization feature
|
@pieper all request have been finished |
|
We have received grant funding for translation of Slicer to French and Spanish, so we would like to revive and integrate this pull request. We'll set up crowdsourcing translation on Weblate. One change that I would consider making is to generate one single .ts file for entire CTK instead of one .ts file for each component (ctkDICOM2, ctkDICOMQueryRetrieve, etc.). Having less .ts files would make managament of translations a bit easier: we would have one .ts file for each major component (Slicer, CTK, and for each extension, about a total of 100) for each language - a total of 1000-2000 files. If we had a .ts file for each component then we could end up with tens of thousands of very small .ts files. |
|
Yes, now that we have some resources more experience with the translation options we can revisit this code and get it merged. @nolden let us know if there are considerations for internationalization of MITK we should take into account for this. |
|
@pieper Thanks! :) Nothing to consider regarding i18n and MITK. |
|
Closing. This pull request was superseded by: |
the modifications below aim to solve the internationalization problem when people who want to use different language to display information when using CTK DICOM Library
the details are described as below:
1、ctkDicomTableView
add a new private member QLabel to store the internal use of queryTableName, use the original QLabel just to display the table view's caption on ui.
add function setDisplayText to set the table view's caption on ui
add a function applyHeaderTextList to supply a way to use different language formating the table column title
2、ctkDICOMQueryRetrieveWidget
set the ctkDICOMQuery Parameters with QApplication::translate() result to solve the internationalization problem
3、ctkDICOMServerNodeWidget
modify addServerNode function to set the table widget column title with QApplication::translate() result to solve the internationalization problem
modify readSettings function to set the default server node parameters with QApplication::translate() result to solve the internationalization problem
4、ctkDICOMTableManager
modify init function, add function call of setDisplayText to patientsTable,studiesTable and seriesTable to format the table view caption with different language