Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete CMake code related to CMake < 3.0 #1111

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Remove obsolete CMake code related to CMake < 3.0 #1111

merged 3 commits into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. COMP: Remove obsolete CMake code related to CMake < 3.0 

    This is a follow-up of these commits:
* 3eb055e (COMP: Update CMake required version from 2.8.9 to 3.0
  to match its use)
* 8840276 (COMP: Require CMake >= 3.0 for project building against CTK)

Summary:

* Update CTK CMake modules removing support for CMake < 3.0.

* Remove CTK own implementation of CMakeFindDependencyMacro already provided
  in CMake >= 3.0.

* Remove unneeded policy settings already set to NEW by virtue of calling
  cmake_minimum_required(VERSION 3.0). Since CMake 3.0 implies all polices
  <= CMP0050 are set to NEW, this commit removes the corresponding code.
    @jcfr
    jcfr committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    2623ff2 View commit details
    Browse the repository at this point in the history

  2. STYLE: Fix indent following removal of obsolete CMake code 

    This is introduced as a separated commit so that .git-blame-ignore-revs
can be updated.
    @jcfr
    jcfr committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    621e8e7 View commit details
    Browse the repository at this point in the history

  3. COMP: Remove obsolete CTK copy of CMakePackageConfigHelpers 

    This commit is a follow-up of bb46b8c (Add support for install-able and
relocatable package.) where a copy of CMakePackageConfigHelpers was integrated
to support configuring using CMake 2.8.7.

This was needed because the module CMakePackageConfigHelpers was introduced
in CMake 2.8.8.

Since CMake 3.0 is now required to build or use CTK, ths commit removes
the obsolete logic checking if the CTK copy of CMakePackageConfigHelpers
needed to be included.

The change is consistent with configure output:

[...]
-- Including CMake built-in module CMakePackageConfigHelpers
-- Including CMake built-in module CMakePackageConfigHelpers - ok
[...]
    @jcfr
    jcfr committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    61aa35b View commit details
    Browse the repository at this point in the history