Remove obsolete CMake code related to CMake < 3.0 #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up of these commits: * 3eb055e (COMP: Update CMake required version from 2.8.9 to 3.0 to match its use) * 8840276 (COMP: Require CMake >= 3.0 for project building against CTK) Summary: * Update CTK CMake modules removing support for CMake < 3.0. * Remove CTK own implementation of CMakeFindDependencyMacro already provided in CMake >= 3.0. * Remove unneeded policy settings already set to NEW by virtue of calling cmake_minimum_required(VERSION 3.0). Since CMake 3.0 implies all polices <= CMP0050 are set to NEW, this commit removes the corresponding code.
This is introduced as a separated commit so that .git-blame-ignore-revs can be updated.
jcfr
force-pushed
the
remove-obsolete-cmake-code
branch
from
bd5bc16
to
621e8e7
Compare
This commit is a follow-up of bb46b8c (Add support for install-able and relocatable package.) where a copy of CMakePackageConfigHelpers was integrated to support configuring using CMake 2.8.7. This was needed because the module CMakePackageConfigHelpers was introduced in CMake 2.8.8. Since CMake 3.0 is now required to build or use CTK, ths commit removes the obsolete logic checking if the CTK copy of CMakePackageConfigHelpers needed to be included. The change is consistent with configure output: [...] -- Including CMake built-in module CMakePackageConfigHelpers -- Including CMake built-in module CMakePackageConfigHelpers - ok [...]
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of these commits:
COMP: Update CMake required version from 2.8.9 to 3.0 to match its use)COMP: Require CMake >= 3.0 for project building against CTK)Add support for install-able and relocatable package.)Summary:
Update CTK CMake modules removing support for CMake < 3.0.
Remove CTK own implementation of
CMakeFindDependencyMacroalready provided in CMake >= 3.0.Remove unneeded policy settings already set to
NEWby virtue of callingcmake_minimum_required(VERSION 3.0). Since CMake 3.0 implies all polices<= CMP0050are set toNEW, this commit removes the corresponding code.Remove unneeded
CMakePackageConfigHelpersoriginally introduced to support CMake 2.8.7 missing the module. It was introduced in CMake 2.8.8.