Update external projects #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
dzenanz
approved these changes
Feb 9, 2021
This comment was marked as outdated.
This comment was marked as outdated.
Users can use whatever versions they need, but we can still set Qt 5 and VTK 8 or 9 as default when someone does not specify any VTK and Qt versions. |
|
FYI: DCMTK 3.6.6 has been released only recently. |
Closed
jcfr
force-pushed
the
update-external-projects
branch
from
22f8c9d
to
68544d5
Compare
Since minimum required CMake version is 3.0 and the fix has been integrated in CMake 2.8.10 (see Kitware/CMake@d63eb0be2), this commit removed the workaround originally introduced in commontk/CTK@4f9c61eb2.
For reference, OpenIGTLink has been removed from Slicer proper and moved to an extension in Slicer/Slicer@724edb05a (ENH: Remove support for building OpenIGTLink now available as an extension)
The dependency was originally introduced to be used in the CTKMessagingCore library but this one has been removed in commontk/CTK@7f2c86ff6 (Removed Messaging library.)
This commit updates to the version of ITK used in Slicer/Slicer@ac87bca5bf and removes obsolete build options
This commit updates to the version of DCMTK used in Slicer/Slicer@ac87bca5bf and also updates the CMake build options to match settings used in Slicer.
This commit updates to the version of DCMTK used in Slicer/Slicer@ee2c0a5c0. It corresponds to the official DCMTK release DCMTK-3.6.6 [1] with an extra backported patch [2] [1] https://git.dcmtk.org/?p=dcmtk.git;a=commit;h=6cb30bd7fb42190e0188afbd8cb961c62a6fb9c9 [2] https://git.dcmtk.org/?p=dcmtk.git;a=commit;h=b665e2ec2d5ce435e28da6c938736dcfa84d0da6
Adapted from Slicer/Slicer@3eb2c42f4 List of DCMTK changes: $ git shortlog f2f7b5ee0..0f9bf4d9e --no-merges Marco Eichelberg (1): [Backport] Made file extensions explicit for CMake CMP0115. This commit fixes warning like the following: CMake Warning (dev) at CMake/dcmtkMacros.cmake:82 (add_library): Policy CMP0115 is not set: Source file extensions must be explicit. Run "cmake --help-policy CMP0115" for policy details. Use the cmake_policy command to set the policy and suppress this warning. File: /path/to/S-r/DCMTK/oflog/libsrc/nullap.cc Call Stack (most recent call first): oflog/libsrc/CMakeLists.txt:10 (DCMTK_ADD_LIBRARY)
Adapted from Slicer/Slicer@88b9fd9e4 Fixes an observed issue where building on Windows with Anaconda in PATH could result in a path being found for nonexistent ICU libraries. Co-authored-by: Tom Birdsong <[email protected]>
This commit fixes the warnings reported when setting CMAKE_CXX_STANDARD
to value corresponding to C++ version newer than C++98.
The differences between the two version are the following:
$ git shortlog c44b32fde..b5324a213 --no-merges
Ben Boeckel (2):
clang-tidy: fix override issues
cmake: add an option for building examples
Edern Haumont (1):
Allow events to be played individually
Utkarsh Ayachit (5):
Fixes issues when test playback fails to find an object.
Add clang-format file (same as ParaView).
Add gitattributes.
clang-format: fix code formatting
Add ability to add custom library prefix/suffix.
* v8.0.1 is the last VTK version officially supporting Qt4 * Support passing CTK_VTK_VERSION_MAJOR to select the VTK version. Default is 9 if building against Qt5, and 8 if building against Qt4. * Options for either Qt4 or Qt5 are passed to the currently selected VTK version based on the value of CTK_QT_VERSION * Initialize VTK_PYTHON_VERSION with PYTHON_VERSION_MAJOR * Remove setting of obsolete options VTK_USE_QT, VTK_USE_GUISUPPORT, DESIRED_QT_VERSION and VTK_USE_QVTK_QTOPENGL. * Set OpenGL_GL_PREFERENCE. See Slicer/Slicer@23d814488 (BUG: Fix linux package removing dependency to GLVND libraries)
jcfr
force-pushed
the
update-external-projects
branch
from
68544d5
to
4cc9bc5
Compare
This was
linked to
issues
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.20.1tov5.1.2DCMTK-3.6.1_20161102toDCMTK-3.6.5